Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OrbitPlotter2D has not method set_frame #480

Closed
Juanlu001 opened this Issue Oct 28, 2018 · 1 comment

Comments

2 participants
@Juanlu001
Copy link
Member

Juanlu001 commented Oct 28, 2018

OrbitPlotter2D should be as consistent as possible with OrbitPlotter, but it's lacking a set_frame method. I noticed this while trying to write a plot_solar_system function that uses the Plotly backend instead.

Juanlu001 added a commit to Juanlu001/poliastro that referenced this issue Oct 28, 2018

WIP: Split plotting backends, default to Plotly
Addresses poliastro#338.

Now trying to import OrbitPlotter directly from poliastro.plotting
fails, because it's the "old" backend and users are encouraged to
use OrbitPlotter2D and OrbitPlotter3D instead, which use plotly
and not matplotlib behind the scenes.

This does not address:

* Updates in documentation
* Failing test because OrbitPlotter2D has no set_frame method (poliastro#480)
* Test simplification and refactoring (poliastro#448 and poliastro#447)

Also, notice that poliastro#281 should be fixed first.
@shreyasbapat

This comment has been minimized.

Copy link
Member

shreyasbapat commented Oct 30, 2018

I will do it :)

Juanlu001 added a commit to Juanlu001/poliastro that referenced this issue Nov 3, 2018

Juanlu001 added a commit to Juanlu001/poliastro that referenced this issue Nov 3, 2018

WIP: Split plotting backends, default to Plotly
Addresses poliastro#338.

Now trying to import OrbitPlotter directly from poliastro.plotting
fails, because it's the "old" backend and users are encouraged to
use OrbitPlotter2D and OrbitPlotter3D instead, which use plotly
and not matplotlib behind the scenes.

This does not address:

* Updates in documentation
* Failing test because OrbitPlotter2D has no set_frame method (poliastro#480)
* Test simplification and refactoring (poliastro#448 and poliastro#447)

Also, notice that poliastro#281 should be fixed first.

Juanlu001 added a commit to Juanlu001/poliastro that referenced this issue Nov 3, 2018

shreyasbapat added a commit to shreyasbapat/poliastro that referenced this issue Nov 3, 2018

Juanlu001 added a commit to Juanlu001/poliastro that referenced this issue Nov 9, 2018

WIP: Split plotting backends, default to Plotly
Addresses poliastro#338.

Now trying to import OrbitPlotter directly from poliastro.plotting
fails, because it's the "old" backend and users are encouraged to
use OrbitPlotter2D and OrbitPlotter3D instead, which use plotly
and not matplotlib behind the scenes.

This does not address:

* Updates in documentation
* Failing test because OrbitPlotter2D has no set_frame method (poliastro#480)
* Test simplification and refactoring (poliastro#448 and poliastro#447)

Also, notice that poliastro#281 should be fixed first.

Juanlu001 added a commit to Juanlu001/poliastro that referenced this issue Nov 9, 2018

@Juanlu001 Juanlu001 self-assigned this Dec 27, 2018

@Juanlu001 Juanlu001 added this to the 0.12 milestone Dec 27, 2018

Juanlu001 added a commit to Juanlu001/poliastro that referenced this issue Jan 4, 2019

Juanlu001 added a commit to Juanlu001/poliastro that referenced this issue Jan 4, 2019

Juanlu001 added a commit to Juanlu001/poliastro that referenced this issue Jan 7, 2019

@Juanlu001 Juanlu001 closed this in eaa71e9 Jan 7, 2019

@wafflebot wafflebot bot removed the 2 - In Progress label Jan 7, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.