Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OrbitPlotter2D has not method set_frame #480

Closed
astrojuanlu opened this issue Oct 28, 2018 · 1 comment
Closed

OrbitPlotter2D has not method set_frame #480

astrojuanlu opened this issue Oct 28, 2018 · 1 comment
Assignees
Milestone

Comments

@astrojuanlu
Copy link
Member

@astrojuanlu astrojuanlu commented Oct 28, 2018

OrbitPlotter2D should be as consistent as possible with OrbitPlotter, but it's lacking a set_frame method. I noticed this while trying to write a plot_solar_system function that uses the Plotly backend instead.

astrojuanlu added a commit to astrojuanlu/poliastro that referenced this issue Oct 28, 2018
Addresses poliastro#338.

Now trying to import OrbitPlotter directly from poliastro.plotting
fails, because it's the "old" backend and users are encouraged to
use OrbitPlotter2D and OrbitPlotter3D instead, which use plotly
and not matplotlib behind the scenes.

This does not address:

* Updates in documentation
* Failing test because OrbitPlotter2D has no set_frame method (poliastro#480)
* Test simplification and refactoring (poliastro#448 and poliastro#447)

Also, notice that poliastro#281 should be fixed first.
@shreyasbapat
Copy link
Member

@shreyasbapat shreyasbapat commented Oct 30, 2018

I will do it :)

astrojuanlu added a commit to astrojuanlu/poliastro that referenced this issue Nov 3, 2018
astrojuanlu added a commit to astrojuanlu/poliastro that referenced this issue Nov 3, 2018
Addresses poliastro#338.

Now trying to import OrbitPlotter directly from poliastro.plotting
fails, because it's the "old" backend and users are encouraged to
use OrbitPlotter2D and OrbitPlotter3D instead, which use plotly
and not matplotlib behind the scenes.

This does not address:

* Updates in documentation
* Failing test because OrbitPlotter2D has no set_frame method (poliastro#480)
* Test simplification and refactoring (poliastro#448 and poliastro#447)

Also, notice that poliastro#281 should be fixed first.
astrojuanlu added a commit to astrojuanlu/poliastro that referenced this issue Nov 3, 2018
shreyasbapat added a commit to shreyasbapat/poliastro that referenced this issue Nov 3, 2018
astrojuanlu added a commit to astrojuanlu/poliastro that referenced this issue Nov 9, 2018
Addresses poliastro#338.

Now trying to import OrbitPlotter directly from poliastro.plotting
fails, because it's the "old" backend and users are encouraged to
use OrbitPlotter2D and OrbitPlotter3D instead, which use plotly
and not matplotlib behind the scenes.

This does not address:

* Updates in documentation
* Failing test because OrbitPlotter2D has no set_frame method (poliastro#480)
* Test simplification and refactoring (poliastro#448 and poliastro#447)

Also, notice that poliastro#281 should be fixed first.
astrojuanlu added a commit to astrojuanlu/poliastro that referenced this issue Nov 9, 2018
@astrojuanlu astrojuanlu self-assigned this Dec 27, 2018
@astrojuanlu astrojuanlu added this to the 0.12 milestone Dec 27, 2018
astrojuanlu added a commit to astrojuanlu/poliastro that referenced this issue Jan 4, 2019
astrojuanlu added a commit to astrojuanlu/poliastro that referenced this issue Jan 4, 2019
astrojuanlu added a commit to astrojuanlu/poliastro that referenced this issue Jan 7, 2019
@ghost ghost removed the 2 - In Progress label Jan 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants