Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

OrbitPlotter2D results are different than OrbitPlotter #483

Closed
astrojuanlu opened this issue Nov 2, 2018 · 2 comments
Closed

OrbitPlotter2D results are different than OrbitPlotter #483

astrojuanlu opened this issue Nov 2, 2018 · 2 comments
Assignees
Milestone

Comments

@astrojuanlu
Copy link
Member

@astrojuanlu astrojuanlu commented Nov 2, 2018

馃悶 Problem

As per the title:

screenshot_2018-11-02 talk

馃枼 Please paste the output of following commands

  • conda info -a (only if you have conda)
  • conda list (only if you have conda)
  • pip freeze
# Paste your output here:
  • python -c "import poliastro.testing; poliastro.testing.test()"
# Paste your output here:

馃幆 Goal

To be able to replace the matplotlib backend with the Plotly backend.

馃挕 Possible solutions

See if fixing #480 fixes this.

馃搵 Steps to solve the problem

  • Comment below about what you've started working on.
  • Add, commit, push your changes
  • Submit a pull request and add this in comments - Addresses #<put issue number here>
  • Ask for a review in comments section of pull request
  • Celebrate your contribution to this project 馃帀
@shreyasbapat
Copy link
Member

@shreyasbapat shreyasbapat commented Nov 3, 2018

I can confirm that it will be fixed on fixing #480 .
Pull Request incoming.

@shreyasbapat
Copy link
Member

@shreyasbapat shreyasbapat commented Nov 3, 2018

image
See the comparison. :)

shreyasbapat added a commit to shreyasbapat/poliastro that referenced this issue Nov 3, 2018
@ghost ghost assigned shreyasbapat Nov 3, 2018
@ghost ghost added the 2 - In Progress label Nov 3, 2018
@astrojuanlu astrojuanlu added this to the 0.12 milestone Dec 27, 2018
@astrojuanlu astrojuanlu mentioned this issue Jan 4, 2019
8 tasks
astrojuanlu added a commit to astrojuanlu/poliastro that referenced this issue Jan 7, 2019
astrojuanlu added a commit to astrojuanlu/poliastro that referenced this issue Jan 7, 2019
@ghost ghost removed the 2 - In Progress label Jan 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants