Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Download progress is not shown in DASTCOM5 #542

Closed
shreyasbapat opened this issue Jan 17, 2019 · 7 comments

Comments

@shreyasbapat
Copy link
Member

commented Jan 17, 2019

馃悶 Problem
The download progress is not shown in DASTCOM5 while running dastcom5.download_dastcom5() .

Instead, a long whitespace is shown.
screenshot from 2019-01-17 22-19-15

This makes the function:
https://github.com/poliastro/poliastro/blob/master/src/poliastro/neos/dastcom5.py#L545-L548

Useless. Also, it is peculiar to see that arguments are not passed to that function. Or atleast I didn't understand how that works.

FTP_DB_URL + "dastcom5.zip", dastcom5_zip_path, _show_download_progress

from poliastro.neos import dastcom5

dastcom.download_dastcom5()

馃枼 Please paste the output of following commands

  • conda info -a (only if you have conda)
  • conda list (only if you have conda)
  • pip freeze
# Paste your output here:
  • python -c "import poliastro.testing; poliastro.testing.test()"
# Paste your output here:

馃幆 Goal

馃挕 Possible solutions

馃搵 Steps to solve the problem

  • Comment below about what you've started working on.
  • Add, commit, push your changes
  • Submit a pull request and add this in comments - Addresses #<put issue number here>
  • Ask for a review in comments section of pull request
  • Celebrate your contribution to this project 馃帀
@amsuhane

This comment has been minimized.

Copy link

commented Feb 3, 2019

I solved the issue in two ways:

  • In the first way I have not used any additional library:
    final_self_bar
  • In the second method I have used the tqdm library. The additional benefit in this method is that estimation time and download speed are also shown.
    final_4tqdm

Which method is preferred?

@Juanlu001

This comment has been minimized.

Copy link
Member

commented Feb 3, 2019

Hi @amsuhane, thanks for tackling this! I guess that in the first solution you implemented the logic yourself? I would not mind depending on tqdm at all. Please send a pull request, or better do it directly to https://github.com/shreyasbapat/astroquery/tree/dastcom (cc @shreyasbapat) which has an open pull request at astropy/astroquery#1339, so it lands in astroquery directly.

@shreyasbapat

This comment has been minimized.

Copy link
Member Author

commented Feb 3, 2019

Hi @amsuhane , I will be glad if you can directly contribute it here: https://github.com/shreyasbapat/astroquery/tree/dastcom
Thanks for your help! :)

@shreyasbapat

This comment has been minimized.

Copy link
Member Author

commented Feb 4, 2019

Being tracked here : shreyasbapat/astroquery#1

@shreyasbapat

This comment has been minimized.

Copy link
Member Author

commented Feb 5, 2019

Do we require the commit to be in poliastro as well?

@Juanlu001

This comment has been minimized.

Copy link
Member

commented Feb 5, 2019

@Juanlu001

This comment has been minimized.

Copy link
Member

commented Feb 23, 2019

Closing this because we won't fix it in poliastro.

@Juanlu001 Juanlu001 closed this Feb 23, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can鈥檛 perform that action at this time.