Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

plotly requires ipywidgets. But this isn't captured in dependencies. Perhaps add to requirements? #548

Closed
jimmyz70 opened this Issue Jan 27, 2019 · 4 comments

Comments

2 participants
@jimmyz70
Copy link

jimmyz70 commented Jan 27, 2019

poliastro install on Mac OS X fails tests. Traced to plotly depending upon FigureWidget. This is found in ipywidgets. Which doesn't get installed during poliastro install. Can this be fixed simply by adding ipywidgets to requirements.txt?

Solution:
My solution was to use pip to manually install ipywidgets.
After that I still had to update matplotlibrc to use TKAgg since python isn't installed as a framework on my Mac.
With those two changes I was able to pass the tests. (With 55 warnings. Mostly about date conversions.)

@Juanlu001

This comment has been minimized.

Copy link
Member

Juanlu001 commented Jan 27, 2019

Hi @jimmyz70, thanks a lot for reporting this issue!

You are totally right: plotly depends only on nbformat, which in turn only depends on jupyter-core.

From my understanding, in the same way that we don't want poliastro to depend on the Jupyter notebook explicitly (since there are people using it without the notebook), I guess plotly.py is in the same situation.

However, I understand that this makes the installation for the notebook more complicated, and that those extra steps are not documented. Therefore, I'm labeling this as a bug in the documentation.

Also:

After that I still had to update matplotlibrc to avoid use TKAgg since python isn't installed as a framework on my Mac.

Could you please detail what are those steps? I am not familiar with OS X.

With those two changes I was able to pass the tests. (With 55 warnings. Mostly about date conversions.)

Yes, there are too many warnings and we want to suppress them to reduce the testing noise.

@Juanlu001

This comment has been minimized.

Copy link
Member

Juanlu001 commented Jan 27, 2019

By the way, we don't use requirements.txt files so with your permission I will edit the issue title.

@Juanlu001 Juanlu001 changed the title plotly requires ipywidgets. But this isn't captured in dependencies. Perhaps add to requirements.txt? plotly requires ipywidgets. But this isn't captured in dependencies. Perhaps add to requirements? Jan 27, 2019

@Juanlu001 Juanlu001 added this to the 0.12 milestone Jan 29, 2019

@Juanlu001

This comment has been minimized.

Copy link
Member

Juanlu001 commented Jan 30, 2019

My idea is to provide a pip install poliastro[jupyter] that brings all the necessary stuff to work with poliastro in Jupyter notebook (and to a certain extent, JupyterLab).

@Juanlu001 Juanlu001 added the 1 - Ready label Feb 2, 2019

@Juanlu001

This comment has been minimized.

Copy link
Member

Juanlu001 commented Feb 9, 2019

I have been bitten by this today while testing the new beta version. Working on a fix.

@Juanlu001 Juanlu001 self-assigned this Feb 9, 2019

@Juanlu001 Juanlu001 added 2 - In Progress and removed 1 - Ready labels Feb 9, 2019

Juanlu001 added a commit to Juanlu001/poliastro that referenced this issue Feb 9, 2019

@Juanlu001 Juanlu001 closed this in 3e9c935 Feb 9, 2019

@wafflebot wafflebot bot removed the 2 - In Progress label Feb 9, 2019

Juanlu001 added a commit to Juanlu001/poliastro that referenced this issue Feb 21, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.