/poliastro

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversion between coe and rv is not transitive #62

Closed
Juanlu001 opened this Issue Jul 2, 2015 · 1 comment

Comments

Assignees

@Juanlu001 Juanlu001

Labels
None yet
Milestone
  0.5
1 participant
@Juanlu001
@Juanlu001
Member

Juanlu001 commented Jul 2, 2015

This is a consequence on my indecision about using the semimajor axis or the semilatus rectum. To avoid singularities and problems (see #37) I should probably move to using the semilatus rectum definitively.

If I make this change, probably the special function introduced in #38 won't be needed anymore.

@Juanlu001 Juanlu001 added bug 1 - Ready labels Jul 2, 2015

@Juanlu001 Juanlu001 self-assigned this Jul 2, 2015

@Juanlu001 Juanlu001 added this to the 0.4 milestone Jul 2, 2015

Juanlu001 added a commit to Juanlu001/poliastro that referenced this issue Jul 2, 2015

@Juanlu001
Added conversion between coe and mee 
The conversion is made transitive and non singular through
the use of semilatus rectum instead of semimajor axis, see poliastro#62.
The case of polar inclination is still pending.
bc3baa4

@Juanlu001 Juanlu001 closed this in 828d328 Jul 3, 2015

@Juanlu001 Juanlu001 removed the 1 - Ready label Jul 3, 2015

@Juanlu001

This comment has been minimized.

Sign in to view
Member

Juanlu001 commented Jan 23, 2016

My indecision still holds, so I'm reopening this issue.

I find myself never dealing with parabolic orbits, yet I introduced this change and I find it extremely annoying for the remaining 100 % of my use cases. I'm thinking of reverting it once and for all.

@Juanlu001 Juanlu001 reopened this Jan 23, 2016

@Juanlu001 Juanlu001 modified the milestones: 0.5, 0.4 Jan 23, 2016

@Juanlu001 Juanlu001 added 1 - Ready 2 - In Progress and removed bug 1 - Ready labels Jan 23, 2016

@Juanlu001 Juanlu001 referenced this issue Jan 23, 2016

Merged

Restore semimajor axis as shape parameter #106

@Juanlu001 Juanlu001 closed this in #106 Jan 23, 2016

@Juanlu001 Juanlu001 removed the 2 - In Progress label Jan 23, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment