Skip to content

/ poliastro

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Conversion between coe and rv is not transitive #62

Closed
astrojuanlu opened this issue Jul 2, 2015 · 1 comment
Closed

Conversion between coe and rv is not transitive #62

astrojuanlu opened this issue Jul 2, 2015 · 1 comment
Assignees
@astrojuanlu
Milestone
0.5

Comments

@astrojuanlu
Copy link
Member

@astrojuanlu astrojuanlu commented Jul 2, 2015

This is a consequence on my indecision about using the semimajor axis or the semilatus rectum. To avoid singularities and problems (see #37) I should probably move to using the semilatus rectum definitively.

If I make this change, probably the special function introduced in #38 won't be needed anymore.
@astrojuanlu astrojuanlu self-assigned this Jul 2, 2015
@astrojuanlu astrojuanlu added this to the 0.4 milestone Jul 2, 2015
astrojuanlu added a commit to astrojuanlu/poliastro that referenced this issue Jul 2, 2015
@astrojuanlu
Added conversion between coe and mee
bc3baa4 
The conversion is made transitive and non singular through
the use of semilatus rectum instead of semimajor axis, see poliastro#62.
The case of polar inclination is still pending.
@astrojuanlu astrojuanlu removed the 1 - Ready label Jul 3, 2015
@astrojuanlu
Copy link
Member Author

@astrojuanlu astrojuanlu commented Jan 23, 2016

My indecision still holds, so I'm reopening this issue.

I find myself never dealing with parabolic orbits, yet I introduced this change and I find it extremely annoying for the remaining 100 % of my use cases. I'm thinking of reverting it once and for all.
@astrojuanlu astrojuanlu reopened this Jan 23, 2016
@astrojuanlu astrojuanlu modified the milestones: 0.5, 0.4 Jan 23, 2016
@astrojuanlu astrojuanlu mentioned this issue Jan 23, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@astrojuanlu astrojuanlu

Labels
None yet
Projects
None yet
Milestone
0.5
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant
@astrojuanlu