Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

0.13.0: Test failure due to a unit problem #761

Closed
olebole opened this issue Aug 17, 2019 · 2 comments
Closed

0.13.0: Test failure due to a unit problem #761

olebole opened this issue Aug 17, 2019 · 2 comments
Assignees

Comments

@olebole
Copy link
Contributor

@olebole olebole commented Aug 17, 2019

馃悶 Problem

When running the tests during build time, I get the following error:

_____________________ [doctest] poliastro.core.util.cross ______________________
143     b : ndarray
144         3 Dimension vector.
145 
146     Examples
147     --------
148     >>> from poliastro.core.util import cross
149     >>> from astropy import units as u
150     >>> i = [1, 0, 0] * u.m
151     >>> j = [0, 1, 0] * u.m
152     >>> cross(i, j)
UNEXPECTED EXCEPTION: TypeError('only dimensionless scalar quantities can be converted to Python scalars')
Traceback (most recent call last):

  File "/usr/lib/python3/dist-packages/astropy/units/quantity.py", line 715, in to_value
    scale = self.unit._to(unit)

  File "/usr/lib/python3/dist-packages/astropy/units/core.py", line 953, in _to
    "'{0!r}' is not a scaled version of '{1!r}'".format(self, other))

astropy.units.core.UnitConversionError: 'Unit("m2")' is not a scaled version of 'Unit(dimensionless)'

and similarly

/build/poliastro-0.13.0/.pybuild/cpython3_3.7/build/poliastro/core/util.py:152: UnexpectedException
______________________ [doctest] poliastro.core.util.norm ______________________
103     vec: ndarray
104         Dimension 3 vector.
105 
106 
107     Examples
108     --------
109     >>> from poliastro.core.util import norm
110     >>> from astropy import units as u
111     >>> vec = [1, 1, 1] * u.m
112     >>> norm(vec)
Expected:
    1.7320508075688772
Got:
    <Quantity 1.73205081 m>

/build/poliastro-0.13.0/.pybuild/cpython3_3.7/build/poliastro/core/util.py:112: DocTestFailure

Any idea here? Astropy version is 3.2.1.

@olebole olebole added the support label Aug 17, 2019
@Juanlu001

This comment has been minimized.

Copy link
Member

@Juanlu001 Juanlu001 commented Aug 17, 2019

Interestingly, these are bugs in our doctests and we never noticed them, perhaps because we only run them with numba. The poliastro.core functions are not meant to be used with units.

@Juanlu001

This comment has been minimized.

Copy link
Member

@Juanlu001 Juanlu001 commented Aug 17, 2019

Thanks @olebole!

@Juanlu001 Juanlu001 added bug documentation and removed support labels Aug 17, 2019
Juanlu001 added a commit to olebole/poliastro that referenced this issue Aug 19, 2019
@Juanlu001 Juanlu001 self-assigned this Aug 19, 2019
@Juanlu001 Juanlu001 closed this in 0f0ac1e Aug 19, 2019
@olebole olebole mentioned this issue Nov 4, 2019
32 of 34 tasks complete
Juanlu001 added a commit to Juanlu001/poliastro that referenced this issue Dec 19, 2019
Juanlu001 added a commit to Juanlu001/poliastro that referenced this issue Dec 19, 2019
Juanlu001 added a commit to Juanlu001/poliastro that referenced this issue Dec 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can鈥檛 perform that action at this time.