Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

binder link: embedded hyperlinks broken #781

Closed
mathematicalmichael opened this issue Oct 10, 2019 · 4 comments 路 Fixed by #793
Closed

binder link: embedded hyperlinks broken #781

mathematicalmichael opened this issue Oct 10, 2019 · 4 comments 路 Fixed by #793

Comments

@mathematicalmichael
Copy link
Contributor

@mathematicalmichael mathematicalmichael commented Oct 10, 2019

馃悶 Problem

Clicking on the binder link in the README leads to a page with broken hyperlinks. Cannot navigate to examples.

The cached version that shows up during loading does work, though.

@Juanlu001

This comment has been minimized.

Copy link
Member

@Juanlu001 Juanlu001 commented Oct 13, 2019

Hi @mathematicalmichael, thanks for your interest in poliastro! You are right, now the links are not being rendered:

Screenshot_2019-10-14 index

I am sure this used to work at some point, we will have to consider some alternatives.

@Juanlu001 Juanlu001 added bug documentation and removed support labels Oct 13, 2019
@shreyasbapat

This comment has been minimized.

Copy link
Member

@shreyasbapat shreyasbapat commented Oct 29, 2019

I faced this similar problem! For me, replacing all the spaces in the name with an '_' (Underscore) worked!

@mathematicalmichael

This comment has been minimized.

Copy link
Contributor Author

@mathematicalmichael mathematicalmichael commented Oct 29, 2019

I faced this similar problem! For me, replacing all the spaces in the name with an '_' (Underscore) worked!

oh yeah, that's definitely it.
not sure if markdown takes escape \ into account, but this is exactly why I err on the side of caution and never use spaces in filenames.

trying %20 instead of _ just to see if that'll do the trick

mathematicalmichael added a commit to mathematicalmichael/poliastro that referenced this issue Oct 29, 2019
addresses poliastro#781 (hopefully... did this manually in the GitHub editor)
@shreyasbapat

This comment has been minimized.

Copy link
Member

@shreyasbapat shreyasbapat commented Nov 2, 2019

Minor change required to finally close this!

shreyasbapat added a commit to shreyasbapat/poliastro that referenced this issue Nov 2, 2019
Juanlu001 added a commit that referenced this issue Nov 3, 2019
Fix #781 : Fix the last broken link
@shreyasbapat shreyasbapat mentioned this issue Nov 5, 2019
32 of 34 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can鈥檛 perform that action at this time.