Skip to content
This repository has been archived by the owner on Oct 14, 2023. It is now read-only.

No check against plotting orbits in different planes? #824

Closed
astrojuanlu opened this issue Dec 21, 2019 · 3 comments · Fixed by #877
Closed

No check against plotting orbits in different planes? #824

astrojuanlu opened this issue Dec 21, 2019 · 3 comments · Fixed by #877
Assignees

Comments

@astrojuanlu
Copy link
Member

🐞 Problem

I suspect that we are not doing any transformation when plotting orbits in different planes.

💡 Possible solutions

First, check that this is the case.

If it is, we should implement change_plane if appropriate (see for example this implementation) and use it in plotting.

📋 Steps to solve the problem

  • Comment below about what you've started working on.
  • Add, commit, push your changes
  • Submit a pull request and add this in comments - Addresses #<put issue number here>
  • Ask for a review in comments section of pull request
  • Celebrate your contribution to this project 🎉
@priyanshurohilla
Copy link
Contributor

i want to work on this issue.

@astrojuanlu
Copy link
Member Author

This can be a bit involved and it depends on a refactoring I'm doing, so I prefer to assign it to myself :)

@astrojuanlu
Copy link
Member Author

No, there's no check, and wrong results are plotted.

Screenshot_2020-03-21 Untitled - Jupyter Notebook

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants