Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

No check against plotting orbits in different planes? #824

Closed
astrojuanlu opened this issue Dec 21, 2019 · 3 comments 路 Fixed by #877
Closed

No check against plotting orbits in different planes? #824

astrojuanlu opened this issue Dec 21, 2019 · 3 comments 路 Fixed by #877
Assignees

Comments

@astrojuanlu
Copy link
Member

@astrojuanlu astrojuanlu commented Dec 21, 2019

馃悶 Problem

I suspect that we are not doing any transformation when plotting orbits in different planes.

馃挕 Possible solutions

First, check that this is the case.

If it is, we should implement change_plane if appropriate (see for example this implementation) and use it in plotting.

馃搵 Steps to solve the problem

  • Comment below about what you've started working on.
  • Add, commit, push your changes
  • Submit a pull request and add this in comments - Addresses #<put issue number here>
  • Ask for a review in comments section of pull request
  • Celebrate your contribution to this project 馃帀
@priyanshurohilla
Copy link
Contributor

@priyanshurohilla priyanshurohilla commented Feb 4, 2020

i want to work on this issue.

@astrojuanlu
Copy link
Member Author

@astrojuanlu astrojuanlu commented Feb 7, 2020

This can be a bit involved and it depends on a refactoring I'm doing, so I prefer to assign it to myself :)

@astrojuanlu
Copy link
Member Author

@astrojuanlu astrojuanlu commented Mar 21, 2020

No, there's no check, and wrong results are plotted.

Screenshot_2020-03-21 Untitled - Jupyter Notebook

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

2 participants