Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

czml tests failing locally because of non-UTC timezones #862

Closed
astrojuanlu opened this issue Mar 15, 2020 · 8 comments
Closed

czml tests failing locally because of non-UTC timezones #862

astrojuanlu opened this issue Mar 15, 2020 · 8 comments
Labels
bug good first issue

Comments

@astrojuanlu
Copy link
Member

@astrojuanlu astrojuanlu commented Mar 15, 2020

🐞 Problem

This is what happens in UTC+01:

$ pytest -vv --lf 
========================================================= test session starts ==========================================================
platform linux -- Python 3.7.4, pytest-5.1.0, py-1.8.0, pluggy-0.12.0 -- /home/juanlu/.pyenv/versions/3.7.4/envs/poliastro37_4/bin/python3.7
cachedir: .pytest_cache
Matplotlib: 3.1.3
Freetype: 2.6.1
rootdir: /home/juanlu/Personal/poliastro/poliastro, inifile: setup.cfg
plugins: cov-2.5.1, mypy-0.4.2, doctestplus-0.5.0, remotedata-0.3.2, mpl-0.10
collected 930 items / 928 deselected / 2 selected                                                                                      
run-last-failure: rerun previous 2 failures

src/poliastro/tests/test_czml.py::test_czml_groundtrack FAILED                                                                   [ 50%]
src/poliastro/tests/test_czml.py::test_czml_ground_station FAILED                                                                [100%]

=============================================================== FAILURES ===============================================================
________________________________________________________ test_czml_groundtrack _________________________________________________________

    @pytest.mark.skipif("czml3" not in sys.modules, reason="requires czml3")
    def test_czml_groundtrack():
    
        start_epoch = molniya.epoch
        end_epoch = molniya.epoch + molniya.period
    
        sample_points = 10
    
        expected_doc = """[{
        "id": "document",
        "version": "1.0",
        "name": "document_packet",
        "clock": {
            "interval": "2000-01-01T12:00:00Z/2000-01-01T23:59:35Z",
            "currentTime": "2000-01-01T12:00:00Z",
            "multiplier": 60,
            "range": "LOOP_STOP",
            "step": "SYSTEM_CLOCK_MULTIPLIER"
        }
    }, {
        "id": "custom_properties",
        "properties": {
            "custom_attractor": true,
            "ellipsoid": [
                {
                    "array": [
                        6378136.6,
                        6378136.6,
                        6356751.9
                    ]
                }
            ],
            "map_url": [
                "https://upload.wikimedia.org/wikipedia/commons/c/c4/Earthmap1000x500compac.jpg"
            ],
            "scene3D": true
        }
    }, {
        "id": 0,
        "availability": "2000-01-01T12:00:00Z/2000-01-01T23:59:35Z",
        "position": {
            "epoch": "2000-01-01T12:00:00Z",
            "interpolationAlgorithm": "LAGRANGE",
            "interpolationDegree": 5,
            "referenceFrame": "INERTIAL",
            "cartesian": [
                0.0,
                10140093.6393,
                -800580.7546,
                -1598722.8246,
                4317.5108,
                17593269.6479,
                8807305.9945,
                17587783.6632,
                8635.0217,
                15276972.8693,
                14840949.3322,
                29636690.9896,
                12952.5325,
                10390291.9946,
                18544487.5609,
                37032485.9349,
                17270.0433,
                4459288.7909,
                20454288.4376,
                40846270.159,
                21587.5541,
                -1827745.3661,
                20778744.495,
                41494193.9337,
                25905.065,
                -7974181.1167,
                19549661.224,
                39039771.3569,
                30222.5758,
                -13412369.429,
                16641263.6853,
                33231835.6785,
                34540.0866,
                -17116767.3657,
                11688710.5829,
                23341815.6655,
                38857.5975,
                -15852598.671,
                3766095.5927,
                7520719.1144,
                43175.1083,
                10140093.6393,
                -800580.7546,
                -1598722.8246,
                47492.6191,
                17593269.6479,
                8807305.9945,
                17587783.6632
            ]
        },
        "billboard": {
            "image": "data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAABAAAAAQCAYAAAAf8/9hAAAAAXNSR0IArs4c6QAAAARnQU1BAACxjwv8YQUAAAAJcEhZcwAADsMAAA7DAcdvqGQAAADJSURBVDhPnZHRDcMgEEMZjVEYpaNklIzSEfLfD4qNnXAJSFWfhO7w2Zc0Tf9QG2rXrEzSUeZLOGm47WoH95x3Hl3jEgilvDgsOQUTqsNl68ezEwn1vae6lceSEEYvvWNT/Rxc4CXQNGadho1NXoJ+9iaqc2xi2xbt23PJCDIB6TQjOC6Bho/sDy3fBQT8PrVhibU7yBFcEPaRxOoeTwbwByCOYf9VGp1BYI1BA+EeHhmfzKbBoJEQwn1yzUZtyspIQUha85MpkNIXB7GizqDEECsAAAAASUVORK5CYII=",
            "show": true
        },
        "label": {
            "text": "Molniya",
            "font": "11pt Lucida Console",
            "style": "FILL",
            "fillColor": {
                "rgba": [
                    125,
                    80,
                    120,
                    255
                ]
            },
            "outlineColor": {
                "rgba": [
                    255,
                    255,
                    0,
                    255
                ]
            },
            "outlineWidth": 1.0
        },
        "path": {
            "resolution": 120,
            "material": {
                "solidColor": {
                    "color": {
                        "rgba": [
                            255,
                            255,
                            0,
                            255
                        ]
                    }
                }
            }
        }
    }, {
        "id": "groundtrack0",
        "availability": "2000-01-01T12:00:00Z/2000-01-01T23:59:35Z",
        "position": {
            "epoch": "2000-01-01T12:00:00Z",
            "interpolationAlgorithm": "LAGRANGE",
            "interpolationDegree": 5,
            "referenceFrame": "INERTIAL",
            "cartesian": [
                0.0,
                6280728.255788034,
                -495875.99989224557,
                -990241.5895687921,
                4317.5108,
                4245756.819479091,
                2125453.716924488,
                4244432.895224581,
                8635.0217,
                2663915.8656318397,
                2587884.4433988784,
                5167885.717379646,
                12952.5325,
                1548100.5195240811,
                2763033.9962378335,
                5517651.292250773,
                17270.0433,
                618022.3343837302,
                2834803.0552899935,
                5660970.791429868,
                21587.5541,
                -250341.43583128517,
                2846010.7675710567,
                5683352.0756686535,
                25905.065,
                -1142958.8118256037,
                2802100.92918071,
                5595666.1546065565,
                30222.5758,
                -2159933.044540537,
                2679915.6206089617,
                5351667.73157586,
                34540.0866,
                -3490752.3604656975,
                2383767.686202804,
                4760273.972119002,
                38857.5975,
                -5630876.894771479,
                1337725.3192625502,
                2671375.634339552,
                43175.1083,
                6280728.255788034,
                -495875.99989224557,
                -990241.5895687921,
                47492.6191,
                4245756.819479091,
                2125453.716924488,
                4244432.895224581
            ]
        },
        "path": {
            "show": true,
            "leadTime": 100,
            "trailTime": 100,
            "resolution": 60,
            "material": {
                "solidColor": {
                    "color": {
                        "rgba": [
                            255,
                            255,
                            0,
                            255
                        ]
                    }
                }
            }
        }
    }]"""
        extractor = CZMLExtractor(start_epoch, end_epoch, sample_points)
    
        extractor.add_orbit(
            molniya,
            rtol=1e-4,
            label_text="Molniya",
            groundtrack_show=True,
            label_fill_color=[125, 80, 120, 255],
        )
    
>       assert repr(extractor.packets) == expected_doc
E       assert '[{\n    "id"... }\n    }\n}]' == '[{\n    "id"... }\n    }\n}]'
E           [{
E               "id": "document",
E               "version": "1.0",
E               "name": "document_packet",
E               "clock": {
E                   "interval": "2000-01-01T12:00:00Z/2000-01-01T23:59:35Z",
E         -         "currentTime": "2000-01-01T11:00:00Z",
E         ?                                     ^
E         +         "currentTime": "2000-01-01T12:00:00Z",
E         ?                                     ^
E                   "multiplier": 60,
E                   "range": "LOOP_STOP",
E                   "step": "SYSTEM_CLOCK_MULTIPLIER"
E               }
E           }, {
E               "id": "custom_properties",
E               "properties": {
E                   "custom_attractor": true,
E                   "ellipsoid": [
E                       {
E                           "array": [
E                               6378136.6,
E                               6378136.6,
E                               6356751.9
E                           ]
E                       }
E                   ],
E                   "map_url": [
E                       "https://upload.wikimedia.org/wikipedia/commons/c/c4/Earthmap1000x500compac.jpg"
E                   ],
E                   "scene3D": true
E               }
E           }, {
E               "id": 0,
E               "availability": "2000-01-01T12:00:00Z/2000-01-01T23:59:35Z",
E               "position": {
E         -         "epoch": "2000-01-01T11:00:00Z",
E         ?                               ^
E         +         "epoch": "2000-01-01T12:00:00Z",
E         ?                               ^
E                   "interpolationAlgorithm": "LAGRANGE",
E                   "interpolationDegree": 5,
E                   "referenceFrame": "INERTIAL",
E                   "cartesian": [
E                       0.0,
E                       10140093.6393,
E                       -800580.7546,
E                       -1598722.8246,
E                       4317.5108,
E                       17593269.6479,
E                       8807305.9945,
E                       17587783.6632,
E                       8635.0217,
E                       15276972.8693,
E                       14840949.3322,
E                       29636690.9896,
E                       12952.5325,
E                       10390291.9946,
E                       18544487.5609,
E                       37032485.9349,
E                       17270.0433,
E                       4459288.7909,
E                       20454288.4376,
E                       40846270.159,
E                       21587.5541,
E                       -1827745.3661,
E                       20778744.495,
E                       41494193.9337,
E                       25905.065,
E                       -7974181.1167,
E                       19549661.224,
E                       39039771.3569,
E                       30222.5758,
E                       -13412369.429,
E                       16641263.6853,
E                       33231835.6785,
E                       34540.0866,
E                       -17116767.3657,
E                       11688710.5829,
E                       23341815.6655,
E                       38857.5975,
E                       -15852598.671,
E                       3766095.5927,
E                       7520719.1144,
E                       43175.1083,
E                       10140093.6393,
E                       -800580.7546,
E                       -1598722.8246,
E                       47492.6191,
E                       17593269.6479,
E                       8807305.9945,
E                       17587783.6632
E                   ]
E               },
E               "billboard": {
E                   "image": "data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAABAAAAAQCAYAAAAf8/9hAAAAAXNSR0IArs4c6QAAAARnQU1BAACxjwv8YQUAAAAJcEhZcwAADsMAAA7DAcdvqGQAAADJSURBVDhPnZHRDcMgEEMZjVEYpaNklIzSEfLfD4qNnXAJSFWfhO7w2Zc0Tf9QG2rXrEzSUeZLOGm47WoH95x3Hl3jEgilvDgsOQUTqsNl68ezEwn1vae6lceSEEYvvWNT/Rxc4CXQNGadho1NXoJ+9iaqc2xi2xbt23PJCDIB6TQjOC6Bho/sDy3fBQT8PrVhibU7yBFcEPaRxOoeTwbwByCOYf9VGp1BYI1BA+EeHhmfzKbBoJEQwn1yzUZtyspIQUha85MpkNIXB7GizqDEECsAAAAASUVORK5CYII=",
E                   "show": true
E               },
E               "label": {
E                   "text": "Molniya",
E                   "font": "11pt Lucida Console",
E                   "style": "FILL",
E                   "fillColor": {
E                       "rgba": [
E                           125,
E                           80,
E                           120,
E                           255
E                       ]
E                   },
E                   "outlineColor": {
E                       "rgba": [
E                           255,
E                           255,
E                           0,
E                           255
E                       ]
E                   },
E                   "outlineWidth": 1.0
E               },
E               "path": {
E                   "resolution": 120,
E                   "material": {
E                       "solidColor": {
E                           "color": {
E                               "rgba": [
E                                   255,
E                                   255,
E                                   0,
E                                   255
E                               ]
E                           }
E                       }
E                   }
E               }
E           }, {
E               "id": "groundtrack0",
E               "availability": "2000-01-01T12:00:00Z/2000-01-01T23:59:35Z",
E               "position": {
E         -         "epoch": "2000-01-01T11:00:00Z",
E         ?                               ^
E         +         "epoch": "2000-01-01T12:00:00Z",
E         ?                               ^
E                   "interpolationAlgorithm": "LAGRANGE",
E                   "interpolationDegree": 5,
E                   "referenceFrame": "INERTIAL",
E                   "cartesian": [
E                       0.0,
E                       6280728.255788034,
E                       -495875.99989224557,
E                       -990241.5895687921,
E                       4317.5108,
E                       4245756.819479091,
E                       2125453.716924488,
E                       4244432.895224581,
E                       8635.0217,
E                       2663915.8656318397,
E                       2587884.4433988784,
E                       5167885.717379646,
E                       12952.5325,
E                       1548100.5195240811,
E                       2763033.9962378335,
E                       5517651.292250773,
E                       17270.0433,
E                       618022.3343837302,
E                       2834803.0552899935,
E                       5660970.791429868,
E                       21587.5541,
E                       -250341.43583128517,
E                       2846010.7675710567,
E                       5683352.0756686535,
E                       25905.065,
E                       -1142958.8118256037,
E                       2802100.92918071,
E                       5595666.1546065565,
E                       30222.5758,
E                       -2159933.044540537,
E                       2679915.6206089617,
E                       5351667.73157586,
E                       34540.0866,
E                       -3490752.3604656975,
E                       2383767.686202804,
E                       4760273.972119002,
E                       38857.5975,
E                       -5630876.894771479,
E                       1337725.3192625502,
E                       2671375.634339552,
E                       43175.1083,
E                       6280728.255788034,
E                       -495875.99989224557,
E                       -990241.5895687921,
E                       47492.6191,
E                       4245756.819479091,
E                       2125453.716924488,
E                       4244432.895224581
E                   ]
E               },
E               "path": {
E                   "show": true,
E                   "leadTime": 100,
E                   "trailTime": 100,
E                   "resolution": 60,
E                   "material": {
E                       "solidColor": {
E                           "color": {
E                               "rgba": [
E                                   255,
E                                   255,
E                                   0,
E                                   255
E                               ]
E                           }
E                       }
E                   }
E               }
E           }]

src/poliastro/tests/test_czml.py:534: AssertionError
_______________________________________________________ test_czml_ground_station _______________________________________________________

    @pytest.mark.skipif("czml3" not in sys.modules, reason="requires czml3")
    def test_czml_ground_station():
        start_epoch = iss.epoch
        end_epoch = iss.epoch + molniya.period
    
        sample_points = 10
    
        expected_doc = """[{
        "id": "document",
        "version": "1.0",
        "name": "document_packet",
        "clock": {
            "interval": "2013-03-18T12:00:00Z/2013-03-18T23:59:35Z",
            "currentTime": "2013-03-18T12:00:00Z",
            "multiplier": 60,
            "range": "LOOP_STOP",
            "step": "SYSTEM_CLOCK_MULTIPLIER"
        }
    }, {
        "id": "custom_properties",
        "properties": {
            "custom_attractor": true,
            "ellipsoid": [
                {
                    "array": [
                        6378136.6,
                        6378136.6,
                        6356751.9
                    ]
                }
            ],
            "map_url": [
                "https://upload.wikimedia.org/wikipedia/commons/c/c4/Earthmap1000x500compac.jpg"
            ],
            "scene3D": true
        }
    }, {
        "id": "GS0",
        "availability": "2013-03-18T12:00:00Z/2013-03-18T23:59:35Z",
        "position": {
            "cartesian": [
                2536956.480228706,
                4771321.193798005,
                3399460.9756358126
            ]
        },
        "billboard": {
            "image": "data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAABAAAAAQCAYAAAAf8/9hAAAAAXNSR0IArs4c6QAAAARnQU1BAACxjwv8YQUAAAAJcEhZcwAADsMAAA7DAcdvqGQAAACvSURBVDhPrZDRDcMgDAU9GqN0lIzijw6SUbJJygUeNQgSqepJTyHG91LVVpwDdfxM3T9TSl1EXZvDwii471fivK73cBFFQNTT/d2KoGpfGOpSIkhUpgUMxq9DFEsWv4IXhlyCnhBFnZcFEEuYqbiUlNwWgMTdrZ3JbQFoEVG53rd8ztG9aPJMnBUQf/VFraBJeWnLS0RfjbKyLJA8FkT5seDYS1Qwyv8t0B/5C2ZmH2/eTGNNBgMmAAAAAElFTkSuQmCC",
            "show": true
        },
        "label": {
            "show": true,
            "text": "GS test",
            "font": "11pt Lucida Console",
            "style": "FILL",
            "fillColor": {
                "rgba": [
                    120,
                    120,
                    120,
                    255
                ]
            },
            "outlineWidth": 1.0
        }
    }, {
        "id": "GS1",
        "availability": "2013-03-18T12:00:00Z/2013-03-18T23:59:35Z",
        "position": {
            "cartesian": [
                4450567.472491674,
                1884083.4338554223,
                4176129.2748575546
            ]
        },
        "billboard": {
            "image": "data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAABAAAAAQCAYAAAAf8/9hAAAAAXNSR0IArs4c6QAAAARnQU1BAACxjwv8YQUAAAAJcEhZcwAADsMAAA7DAcdvqGQAAACvSURBVDhPrZDRDcMgDAU9GqN0lIzijw6SUbJJygUeNQgSqepJTyHG91LVVpwDdfxM3T9TSl1EXZvDwii471fivK73cBFFQNTT/d2KoGpfGOpSIkhUpgUMxq9DFEsWv4IXhlyCnhBFnZcFEEuYqbiUlNwWgMTdrZ3JbQFoEVG53rd8ztG9aPJMnBUQf/VFraBJeWnLS0RfjbKyLJA8FkT5seDYS1Qwyv8t0B/5C2ZmH2/eTGNNBgMmAAAAAElFTkSuQmCC",
            "show": true
        },
        "label": {
            "show": false,
            "font": "11pt Lucida Console",
            "style": "FILL",
            "outlineWidth": 1.0
        }
    }]"""
        extractor = CZMLExtractor(start_epoch, end_epoch, sample_points)
    
        extractor.add_ground_station(
            [32 * u.degree, 62 * u.degree],
            label_fill_color=[120, 120, 120, 255],
            label_text="GS test",
        )
    
        extractor.add_ground_station([0.70930 * u.rad, 0.40046 * u.rad], label_show=False)
>       assert repr(extractor.packets) == expected_doc
E       assert '[{\n    "id"....0\n    }\n}]' == '[{\n    "id"....0\n    }\n}]'
E           [{
E               "id": "document",
E               "version": "1.0",
E               "name": "document_packet",
E               "clock": {
E                   "interval": "2013-03-18T12:00:00Z/2013-03-18T23:59:35Z",
E         -         "currentTime": "2013-03-18T11:00:00Z",
E         ?                                     ^
E         +         "currentTime": "2013-03-18T12:00:00Z",
E         ?                                     ^
E                   "multiplier": 60,
E                   "range": "LOOP_STOP",
E                   "step": "SYSTEM_CLOCK_MULTIPLIER"
E               }
E           }, {
E               "id": "custom_properties",
E               "properties": {
E                   "custom_attractor": true,
E                   "ellipsoid": [
E                       {
E                           "array": [
E                               6378136.6,
E                               6378136.6,
E                               6356751.9
E                           ]
E                       }
E                   ],
E                   "map_url": [
E                       "https://upload.wikimedia.org/wikipedia/commons/c/c4/Earthmap1000x500compac.jpg"
E                   ],
E                   "scene3D": true
E               }
E           }, {
E               "id": "GS0",
E               "availability": "2013-03-18T12:00:00Z/2013-03-18T23:59:35Z",
E               "position": {
E                   "cartesian": [
E                       2536956.480228706,
E                       4771321.193798005,
E                       3399460.9756358126
E                   ]
E               },
E               "billboard": {
E                   "image": "data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAABAAAAAQCAYAAAAf8/9hAAAAAXNSR0IArs4c6QAAAARnQU1BAACxjwv8YQUAAAAJcEhZcwAADsMAAA7DAcdvqGQAAACvSURBVDhPrZDRDcMgDAU9GqN0lIzijw6SUbJJygUeNQgSqepJTyHG91LVVpwDdfxM3T9TSl1EXZvDwii471fivK73cBFFQNTT/d2KoGpfGOpSIkhUpgUMxq9DFEsWv4IXhlyCnhBFnZcFEEuYqbiUlNwWgMTdrZ3JbQFoEVG53rd8ztG9aPJMnBUQf/VFraBJeWnLS0RfjbKyLJA8FkT5seDYS1Qwyv8t0B/5C2ZmH2/eTGNNBgMmAAAAAElFTkSuQmCC",
E                   "show": true
E               },
E               "label": {
E                   "show": true,
E                   "text": "GS test",
E                   "font": "11pt Lucida Console",
E                   "style": "FILL",
E                   "fillColor": {
E                       "rgba": [
E                           120,
E                           120,
E                           120,
E                           255
E                       ]
E                   },
E                   "outlineWidth": 1.0
E               }
E           }, {
E               "id": "GS1",
E               "availability": "2013-03-18T12:00:00Z/2013-03-18T23:59:35Z",
E               "position": {
E                   "cartesian": [
E                       4450567.472491674,
E                       1884083.4338554223,
E                       4176129.2748575546
E                   ]
E               },
E               "billboard": {
E                   "image": "data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAABAAAAAQCAYAAAAf8/9hAAAAAXNSR0IArs4c6QAAAARnQU1BAACxjwv8YQUAAAAJcEhZcwAADsMAAA7DAcdvqGQAAACvSURBVDhPrZDRDcMgDAU9GqN0lIzijw6SUbJJygUeNQgSqepJTyHG91LVVpwDdfxM3T9TSl1EXZvDwii471fivK73cBFFQNTT/d2KoGpfGOpSIkhUpgUMxq9DFEsWv4IXhlyCnhBFnZcFEEuYqbiUlNwWgMTdrZ3JbQFoEVG53rd8ztG9aPJMnBUQf/VFraBJeWnLS0RfjbKyLJA8FkT5seDYS1Qwyv8t0B/5C2ZmH2/eTGNNBgMmAAAAAElFTkSuQmCC",
E                   "show": true
E               },
E               "label": {
E                   "show": false,
E                   "font": "11pt Lucida Console",
E                   "style": "FILL",
E                   "outlineWidth": 1.0
E               }
E           }]

src/poliastro/tests/test_czml.py:632: AssertionError
=========================================================== warnings summary ===========================================================
/home/juanlu/.pyenv/versions/3.7.4/envs/poliastro37_4/lib/python3.7/site-packages/nbformat/notebooknode.py:4
  /home/juanlu/.pyenv/versions/3.7.4/envs/poliastro37_4/lib/python3.7/site-packages/nbformat/notebooknode.py:4: DeprecationWarning:
  
  Using or importing the ABCs from 'collections' instead of from 'collections.abc' is deprecated, and in 3.8 it will stop working

-- Docs: https://docs.pytest.org/en/latest/warnings.html
============================================ 2 failed, 928 deselected, 1 warnings in 10.44s ============================================

🖥 Please paste the output of following commands

  • pip freeze
alabaster==0.7.12
appdirs==1.4.3
asn1crypto==0.24.0
astropy==4.0
astroquery==0.4
atomicwrites==1.3.0
attrs==19.3.0
Babel==2.7.0
backcall==0.1.0
beautifulsoup4==4.8.2
black==19.10b0
bleach==3.1.0
cached-property==1.5.1
certifi==2019.11.28
cffi==1.14.0
chardet==3.0.4
Click==7.0
coverage==4.5.4
cryptography==2.8
cycler==0.10.0
czml3==0.4.0
decorator==4.4.0
defusedxml==0.6.0
docutils==0.15.2
entrypoints==0.3
filelock==3.0.12
flit==2.2.0
flit-core==2.2.0
html5lib==1.0.1
idna==2.9
imagesize==1.1.0
importlib-metadata==1.5.0
ipykernel==5.1.2
ipython==7.7.0
ipython-genutils==0.2.0
ipywidgets==7.5.1
isort==4.3.21
jedi==0.15.1
jeepney==0.4.2
Jinja2==2.10.1
jplephem==2.13
jsonschema==3.0.2
jupyter-client==5.3.4
jupyter-core==4.6.1
jupytext==1.3.1
keyring==21.1.0
kiwisolver==1.1.0
llvmlite==0.31.0
MarkupSafe==1.1.1
matplotlib==3.1.3
mistune==0.8.4
more-itertools==7.2.0
mypy==0.760
mypy-extensions==0.4.3
nbconvert==5.6.0
nbformat==4.4.0
nbsphinx==0.5.0
nose==1.3.7
notebook==6.0.2
numba==0.48.0
numpy==1.18.1
packaging==19.1
pandas==1.0.1
pandocfilters==1.4.2
parso==0.5.1
pathspec==0.6.0
pexpect==4.7.0
pickleshare==0.7.5
pkginfo==1.5.0.1
plotly==4.5.2
pluggy==0.12.0
poliastro==0.14.post0.dev0
prometheus-client==0.7.1
prompt-toolkit==2.0.9
ptyprocess==0.6.0
py==1.8.0
pycodestyle==2.5.0
pycparser==2.19
Pygments==2.4.2
pyparsing==2.4.6
pyrsistent==0.15.4
pytest==5.1.0
pytest-cov==2.5.1
pytest-doctestplus==0.5.0
pytest-mpl==0.10
pytest-mypy==0.4.2
pytest-remotedata==0.3.2
python-dateutil==2.8.1
pytoml==0.1.21
pytz==2019.3
PyYAML==5.2
pyzmq==18.1.0
readme-renderer==24.0
regex==2019.12.19
requests==2.23.0
requests-toolbelt==0.9.1
retrying==1.3.3
scipy==1.4.1
SecretStorage==3.1.2
Send2Trash==1.5.0
six==1.14.0
snowballstemmer==1.9.0
soupsieve==2.0
Sphinx==2.1.2
sphinx-hoverxref==0.1b1
sphinx-notfound-page==0.4
sphinx-rtd-theme==0.4.3+require.redef
sphinxcontrib-applehelp==1.0.1
sphinxcontrib-devhelp==1.0.1
sphinxcontrib-htmlhelp==1.0.2
sphinxcontrib-jsmath==1.0.1
sphinxcontrib-qthelp==1.0.2
sphinxcontrib-serializinghtml==1.1.3
terminado==0.8.3
testpath==0.4.2
toml==0.10.0
tornado==6.0.3
tox==3.14.5
tqdm==4.40.2
traitlets==4.3.2
twine==3.1.1
typed-ast==1.4.0
typing-extensions==3.7.4.1
urllib3==1.25.8
virtualenv==16.7.3
w3lib==1.21.0
wcwidth==0.1.7
webencodings==0.5.1
widgetsnbextension==3.5.1
zipp==3.0.0

💡 Possible solutions

📋 Steps to solve the problem

  • Comment below about what you've started working on.
  • Add, commit, push your changes
  • Submit a pull request and add this in comments - Addresses #<put issue number here>
  • Ask for a review in comments section of pull request
  • Celebrate your contribution to this project 🎉
@astrojuanlu astrojuanlu added bug good first issue labels Mar 15, 2020
@priyanshurohilla
Copy link
Contributor

@priyanshurohilla priyanshurohilla commented Mar 15, 2020

We just have to paste the output of the command? What exactly we have to do @astrojuanlu

@astrojuanlu
Copy link
Member Author

@astrojuanlu astrojuanlu commented Mar 15, 2020

@priyanshurohilla I bet you are outside of UTC+00 too, right? Therefore, try to run pytest -k czml, observe how they fail, work on a solution, and open a pull request :)

@priyanshurohilla
Copy link
Contributor

@priyanshurohilla priyanshurohilla commented Mar 15, 2020

Yes I am outside UTC , Ok I would like to work on it!!

@tomaszmrugalski
Copy link
Contributor

@tomaszmrugalski tomaszmrugalski commented Mar 18, 2020

Hi there! First of all, thanks a lot for the work on poliastro. It's a great project than I just started to learn.

I'd like to tackle this problem. I've set up the environment and replicated the issue. Two czml unit-tests are failing for me:

FAILED poliastro/tests/test_czml.py::test_czml_groundtrack
FAILED poliastro/tests/test_czml.py::test_czml_ground_station

I'm in CET timezone (UTC+1), so it fails with an hour difference, exactly the same as reported:

E         -         "currentTime": "2013-03-18T12:00:00Z",
E         ?                                     ^
E         +         "currentTime": "2013-03-18T11:00:00Z",
E         ?                                     ^

I think the fix should update CZMLExtractor class to always use UTC, rather than local timezone. Still learning about CZML syntax and CZMLExtractor. It looks like the problem is with the initial packet, so the fix will be done most likely in init_czml. Hopefully, I won't need to touch the undelying czml3 package. However, one thing is puzzling. I need to also look at why exactly this timezone problem manifests itself in those two tests, but the other 3 czml tests are working fine. Perhaps I'll write a new test that's trimmed down version of the existing one?

Hey @astrojuanlu! Is this the right direction?

Also, is it OK to add comments to the tests in the same MR?

@astrojuanlu
Copy link
Member Author

@astrojuanlu astrojuanlu commented Mar 18, 2020

Hey @tomaszmrugalski, looks like you're on the right direction! Yeah please, new comments and tests are always welcome :)

@astrojuanlu
Copy link
Member Author

@astrojuanlu astrojuanlu commented Mar 18, 2020

Also, this library might be helpful https://pypi.org/project/freezegun/

@tomaszmrugalski
Copy link
Contributor

@tomaszmrugalski tomaszmrugalski commented Mar 18, 2020 •
edited

I now know why test_czml_add_orbit was "passing". There was an assert missing in line 306. Now it started failing, too. :)

Thanks a lot for the tip. Still learning python basics. freezegun looks much more convenient than changing time and timezones of the whole system.

@tomaszmrugalski tomaszmrugalski mentioned this issue Mar 19, 2020
Merged
@astrojuanlu
Copy link
Member Author

@astrojuanlu astrojuanlu commented Mar 20, 2020

I confirm that #872 fixed this. Closing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug good first issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@astrojuanlu @tomaszmrugalski @priyanshurohilla