Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error in porkchop docstrings #892

Closed
jorgepiloto opened this issue Apr 3, 2020 · 6 comments
Closed

Error in porkchop docstrings #892

jorgepiloto opened this issue Apr 3, 2020 · 6 comments
Labels
good first issue Easy tasks for beginners triaging:bug

Comments

@jorgepiloto
Copy link
Member

jorgepiloto commented Apr 3, 2020

馃悶 Problem

While working with poliastro.plotting.porkchop I noticed that the docstring
regarding the output values for the porkchop function is not updated. There
are two missing values: dv_launch and dv_arrival. Both should be included.

馃挕 Possible solutions

  • Add corresponding function docstrings.

馃搵 Steps to solve the problem

  • Add, commit, run tests and push your changes
  • Submit a pull request and add this in comments - Addresses #<put issue number here>
  • Ask for a review in comments section of pull request
  • Celebrate your contribution to this project 馃帀
@jorgepiloto jorgepiloto added triaging:bug good first issue Easy tasks for beginners labels Apr 3, 2020
@iamabhishek0
Copy link
Contributor

iamabhishek0 commented Apr 3, 2020

@jorgepiloto I would like to fix it. Will make a PR soon.

@jorgepiloto
Copy link
Member Author

jorgepiloto commented Apr 3, 2020

Thank you @iamabhishek0! 馃殌

@iamabhishek0
Copy link
Contributor

iamabhishek0 commented Apr 3, 2020

@priyanshurohilla I was working on it :)

@jorgepiloto
Copy link
Member Author

jorgepiloto commented Apr 3, 2020

@iamabhishek0 There is no problem usually if two users working on the same issue. We do normally merge the first PR to success all reviews and code tests 馃殌

@iamabhishek0
Copy link
Contributor

iamabhishek0 commented Apr 3, 2020

@jorgepiloto Sure, will keep that in mind.

@astrojuanlu
Copy link
Member

astrojuanlu commented Apr 4, 2020

Closed in #893.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Easy tasks for beginners triaging:bug
Projects
None yet
Development

No branches or pull requests

3 participants