Skip to content
This repository was archived by the owner on Oct 14, 2023. It is now read-only.

Error in porkchop docstrings #892

Closed
jorgepiloto opened this issue Apr 3, 2020 · 6 comments
Closed

Error in porkchop docstrings #892

jorgepiloto opened this issue Apr 3, 2020 · 6 comments
Labels
good first issue Easy tasks for beginners triaging:bug

Comments

@jorgepiloto
Copy link
Member

🐞 Problem

While working with poliastro.plotting.porkchop I noticed that the docstring
regarding the output values for the porkchop function is not updated. There
are two missing values: dv_launch and dv_arrival. Both should be included.

💡 Possible solutions

  • Add corresponding function docstrings.

📋 Steps to solve the problem

  • Add, commit, run tests and push your changes
  • Submit a pull request and add this in comments - Addresses #<put issue number here>
  • Ask for a review in comments section of pull request
  • Celebrate your contribution to this project 🎉
@jorgepiloto jorgepiloto added triaging:bug good first issue Easy tasks for beginners labels Apr 3, 2020
@iamabhishek0
Copy link
Contributor

@jorgepiloto I would like to fix it. Will make a PR soon.

@jorgepiloto
Copy link
Member Author

Thank you @iamabhishek0! 🚀

@iamabhishek0
Copy link
Contributor

@priyanshurohilla I was working on it :)

@jorgepiloto
Copy link
Member Author

@iamabhishek0 There is no problem usually if two users working on the same issue. We do normally merge the first PR to success all reviews and code tests 🚀

@iamabhishek0
Copy link
Contributor

@jorgepiloto Sure, will keep that in mind.

@astrojuanlu
Copy link
Member

Closed in #893.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
good first issue Easy tasks for beginners triaging:bug
Projects
None yet
Development

No branches or pull requests

3 participants