Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Orbit.from_sbdb raises unhelpful error if no object was found #916

Closed
astrojuanlu opened this issue Apr 18, 2020 · 5 comments
Closed

Orbit.from_sbdb raises unhelpful error if no object was found #916

astrojuanlu opened this issue Apr 18, 2020 · 5 comments
Labels
bug good first issue

Comments

@astrojuanlu
Copy link
Member

@astrojuanlu astrojuanlu commented Apr 18, 2020

In [9]: Orbit.from_sbdb("67/P")
---------------------------------------------------------------------------
KeyError                                  Traceback (most recent call last)
<ipython-input-9-75d3da3ffd57> in <module>
----> 1 Orbit.from_sbdb("67/P")

~/.pyenv/versions/poliastro37_4/lib/python3.7/site-packages/poliastro/twobody/orbit.py in from_sbdb(cls, name, **kargs)
    572             )
    573 
--> 574         a = obj["orbit"]["elements"]["a"].to(u.AU) * u.AU
    575         ecc = float(obj["orbit"]["elements"]["e"]) * u.one
    576         inc = obj["orbit"]["elements"]["i"].to(u.deg) * u.deg

KeyError: 'orbit'

It should give something more meaningful, like ValueError("Object 67/P not found")

@astrojuanlu astrojuanlu added bug good first issue labels Apr 18, 2020
@priyanshurohilla

This comment has been minimized.

@priyanshurohilla

This comment has been minimized.

@astrojuanlu

This comment has been minimized.

@priyanshurohilla

This comment has been minimized.

@astrojuanlu
Copy link
Member Author

@astrojuanlu astrojuanlu commented Apr 19, 2020

Fixed in #919!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug good first issue
Projects
None yet
Development

No branches or pull requests

2 participants