Skip to content
This repository has been archived by the owner on Oct 14, 2023. It is now read-only.

Units error in COESA amtospheric models #992

Closed
jorgepiloto opened this issue Jul 11, 2020 · 1 comment 路 Fixed by #993
Closed

Units error in COESA amtospheric models #992

jorgepiloto opened this issue Jul 11, 2020 · 1 comment 路 Fixed by #993
Labels
good first issue Easy tasks for beginners triaging:bug

Comments

@jorgepiloto
Copy link
Member

馃悶 Problem

I just noticed that the universal gas constant defined in both coesa62.py and coesa76.py hold wrong units: they make use of u.J / u.kg / u.K while proper units should be u.J / u.kmol / u.K. Though defined with wrong units, no errors were raised since code does not make use of those variables.

R = 8314.32 * u.J / u.kg / u.K

R = 8314.32 * u.J / u.kg / u.K

When the universal gas constant is divided by the mean molecular weight of the gas (with u.kg / u.kmol), the specific gas constant is obtained with units u.J / u.kg / u.K.

馃挕 Possible solutions

Either delete de variables or correct their units will solve for this problem.

@jorgepiloto jorgepiloto added triaging:bug good first issue Easy tasks for beginners labels Jul 11, 2020
@rafaellehmkuhl
Copy link
Contributor

I will send a PR for this one.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
good first issue Easy tasks for beginners triaging:bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants