-
-
Notifications
You must be signed in to change notification settings - Fork 288
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1053 +/- ##
=======================================
Coverage 88.65% 88.65%
=======================================
Files 77 77
Lines 4037 4037
Branches 348 347 -1
=======================================
Hits 3579 3579
Misses 366 366
Partials 92 92
Continue to review full report at Codecov.
|
As expected, MyPy and the slow tests (including the docs) failed. But I actually like how this simplifies the code, and the burden on the user side is only moderate. We could add a helper to assemble several perturbations together (or just leave it like that). |
640aebb
to
d05ddfd
Compare
Congrats on this, the implementation is very clean. I really like this new approach, as now the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just left one comment on a parameter which seems not to be used inside a __call__
method. All the rest modifications look good by my side 👍
Merging! Welcome to the future 🚀 |
See discussion in gh-1052. Did not run the "slow" tests or the notebooks, they will probably fail.