Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor cowell #1053

Merged
merged 4 commits into from Jan 1, 2021
Merged

Refactor cowell #1053

merged 4 commits into from Jan 1, 2021

Conversation

astrojuanlu
Copy link
Member

See discussion in gh-1052. Did not run the "slow" tests or the notebooks, they will probably fail.

@codecov
Copy link

codecov bot commented Dec 30, 2020

Codecov Report

Merging #1053 (0ce8754) into master (01ee494) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1053   +/-   ##
=======================================
  Coverage   88.65%   88.65%           
=======================================
  Files          77       77           
  Lines        4037     4037           
  Branches      348      347    -1     
=======================================
  Hits         3579     3579           
  Misses        366      366           
  Partials       92       92           
Impacted Files Coverage Δ
src/poliastro/core/propagation/__init__.py 94.33% <100.00%> (-0.02%) ⬇️
src/poliastro/earth/__init__.py 100.00% <100.00%> (ø)
src/poliastro/twobody/events.py 100.00% <100.00%> (ø)
src/poliastro/twobody/propagation.py 91.66% <100.00%> (-0.42%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 01ee494...0ce8754. Read the comment docs.

@astrojuanlu
Copy link
Member Author

As expected, MyPy and the slow tests (including the docs) failed. But I actually like how this simplifies the code, and the burden on the user side is only moderate. We could add a helper to assemble several perturbations together (or just leave it like that).

@astrojuanlu astrojuanlu temporarily deployed to validation-env January 1, 2021 20:58 Inactive
@astrojuanlu astrojuanlu temporarily deployed to validation-env January 1, 2021 21:02 Inactive
@jorgepiloto
Copy link
Member

Congrats on this, the implementation is very clean. I really like this new approach, as now the func_twobody is the "true" two-body function. In addition, looks like all the test passed 👏

Copy link
Member

@jorgepiloto jorgepiloto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just left one comment on a parameter which seems not to be used inside a __call__ method. All the rest modifications look good by my side 👍

src/poliastro/twobody/events.py Show resolved Hide resolved
@astrojuanlu astrojuanlu merged commit c3836dc into poliastro:master Jan 1, 2021
1 of 2 checks passed
@astrojuanlu
Copy link
Member Author

Merging! Welcome to the future 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants