Remove deprecated Orbit.from_body_ephem and its tests

[ishanSrt]

Closes #1095

[codecov]

Codecov Report

Merging #1110 (6a7befe) into main (3c1d0eb) will decrease coverage by 0.39%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1110      +/-   ##
==========================================
- Coverage   90.02%   89.63%   -0.40%     
==========================================
  Files          73       73              
  Lines        3861     3870       +9     
  Branches      330      332       +2     
==========================================
- Hits         3476     3469       -7     
- Misses        297      313      +16     
  Partials       88       88              

Impacted Files	Coverage Δ
src/poliastro/plotting/_base.py	87.83% <100.00%> (+0.78%)	⬆️
src/poliastro/twobody/orbit.py	79.64% <0.00%> (-3.54%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3c1d0eb...6a7befe. Read the comment docs.

[ishanSrt]

Should I add a decorator to the deprecated function and add it to the exclude_lines for coveragerc @astrojuanlu ?

[astrojuanlu]

Hello @ishanSrt , sorry for the delay! Are you able to see the Quality failures? In the logs, I see this:

2021-02-14T17:19:12.4724784Z check run-test: commands[0] | flake8 src tests
2021-02-14T17:19:16.2979791Z tests/tests_twobody/test_orbit.py:21:1: F401 'poliastro.bodies.Pluto' imported but unused
2021-02-14T17:19:16.2980742Z tests/tests_twobody/test_orbit.py:40:1: F401 'poliastro.frames.equatorial.ICRS' imported but unused
2021-02-14T17:19:16.2981616Z tests/tests_twobody/test_orbit.py:55:1: F401 'poliastro.warnings.TimeScaleWarning' imported but unused
2021-02-14T17:19:16.3174916Z ERROR: InvocationError for command /home/vsts/work/1/s/.tox/check/bin/flake8 src tests (exited with code 1)

please address this proactively so we can focus on the interesting parts of the review :)

[astrojuanlu]

Interestingly, the image tests failed, which suggests that there are some pixel differences. @ishanSrt do you know how to investigate those?

[ishanSrt]

I don't @astrojuanlu but can you point me to some documentation? and I'll look

[ishanSrt]

Interestingly, the image tests failed, which suggests that there are some pixel differences. @ishanSrt do you know how to investigate those?

also they aren't faling locally on my machine, I'll have to add the CI to my repo and spit the output out somewhere, for debugging

[astrojuanlu]

@ishanSrt If they're failing on CI but not locally, perhaps you have to rebuild your tox environment. Something like:

$ tox -e -r py38-images

(only do -r once to save time)

Can you confirm whether this passes or breaks?

[astrojuanlu]

Also, this will need a rebase

[ishanSrt]

Should I add a decorator to the deprecated function and add it to the exclude_lines for coveragerc @astrojuanlu ?

@astrojuanlu please review

[astrojuanlu]

Thanks for this @ishanSrt and sorry for the long delay 🙏🏽 This can be merged already.