Skip to content
This repository has been archived by the owner on Oct 14, 2023. It is now read-only.

Move flyby computation to core #1184

Merged
merged 1 commit into from May 16, 2021

Conversation

Yash-10
Copy link
Member

@Yash-10 Yash-10 commented Apr 24, 2021

This PR tries to move computations for threebody flybys to core.

Thanks!

@codecov
Copy link

codecov bot commented Apr 24, 2021

Codecov Report

Merging #1184 (265fce2) into main (dfcce38) will increase coverage by 0.02%.
The diff coverage is 100.00%.

❗ Current head 265fce2 differs from pull request most recent head bfff0aa. Consider uploading reports for the commit bfff0aa to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1184      +/-   ##
==========================================
+ Coverage   90.27%   90.30%   +0.02%     
==========================================
  Files          76       77       +1     
  Lines        4071     4083      +12     
  Branches      363      363              
==========================================
+ Hits         3675     3687      +12     
  Misses        306      306              
  Partials       90       90              
Impacted Files Coverage Δ
src/poliastro/core/flybys.py 100.00% <100.00%> (ø)
src/poliastro/threebody/flybys.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 598fb29...bfff0aa. Read the comment docs.

@Yash-10 Yash-10 force-pushed the Threebody-computations-to-core branch 3 times, most recently from 265fce2 to 72433dd Compare May 2, 2021 05:26
@Yash-10 Yash-10 force-pushed the Threebody-computations-to-core branch 2 times, most recently from 67956fe to a71121a Compare May 11, 2021 08:10
@Yash-10 Yash-10 force-pushed the Threebody-computations-to-core branch from a71121a to be01fa8 Compare May 12, 2021 09:50
Add float type of v_spacecraft to docstring

Change k units in test argument
@Yash-10 Yash-10 force-pushed the Threebody-computations-to-core branch from be01fa8 to bfff0aa Compare May 12, 2021 09:55
@Yash-10
Copy link
Member Author

Yash-10 commented May 12, 2021

@astrojuanlu Could you take a look at this transfer of computation?

It also seems that the codecov/patch test needs a fix.

Thanks!

Copy link
Member

@astrojuanlu astrojuanlu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is good to go, thanks @Yash-10 and sorry for the delay!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants