Skip to content
This repository has been archived by the owner on Oct 14, 2023. It is now read-only.

Slight modification to shadow_function #1243

Merged
merged 1 commit into from Jun 12, 2021

Conversation

Yash-10
Copy link
Member

@Yash-10 Yash-10 commented Jun 8, 2021

I thought the existing shadow_function checked for the condition:

theta < theta_1 + theta_2

which, according to the description in Howard Curtis returns False if a satellite is in earth's shadow.

Here, I tried to just change the condition so that the function returns True if the satellite is in earth's shadow. rather than False. This modification would make it more clearer?

Add unit description

Reformat
@codecov
Copy link

codecov bot commented Jun 8, 2021

Codecov Report

Merging #1243 (052df6f) into main (112cba6) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1243   +/-   ##
=======================================
  Coverage   90.82%   90.82%           
=======================================
  Files          78       78           
  Lines        4121     4121           
  Branches      363      363           
=======================================
  Hits         3743     3743           
  Misses        288      288           
  Partials       90       90           
Impacted Files Coverage Δ
src/poliastro/core/perturbations.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 112cba6...052df6f. Read the comment docs.

Copy link
Member

@astrojuanlu astrojuanlu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fair enough! Yes I think it's more clear now :) And also thanks for the docstring improvements!

@astrojuanlu astrojuanlu merged commit 3acb5c8 into poliastro:main Jun 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants