Navigation Menu

Skip to content
This repository has been archived by the owner on Oct 14, 2023. It is now read-only.

czml computation to core #1252

Merged
merged 3 commits into from Jun 13, 2021
Merged

czml computation to core #1252

merged 3 commits into from Jun 13, 2021

Conversation

Yash-10
Copy link
Member

@Yash-10 Yash-10 commented Jun 13, 2021

This pull request tries to move computations of czml/utils.py to core since it uses numpy and has some heavy calculations.

Thanks!

@codecov
Copy link

codecov bot commented Jun 13, 2021

Codecov Report

Merging #1252 (8c505c7) into main (788a573) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1252   +/-   ##
=======================================
  Coverage   91.29%   91.30%           
=======================================
  Files          79       79           
  Lines        4135     4138    +3     
  Branches      360      359    -1     
=======================================
+ Hits         3775     3778    +3     
  Misses        270      270           
  Partials       90       90           
Impacted Files Coverage Δ
src/poliastro/core/czml_utils.py 100.00% <100.00%> (ø)
src/poliastro/czml/extract_czml.py 88.09% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 788a573...8c505c7. Read the comment docs.

Copy link
Member

@astrojuanlu astrojuanlu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Yash-10 !

@astrojuanlu astrojuanlu merged commit c1ffbaa into poliastro:main Jun 13, 2021
@Yash-10 Yash-10 deleted the Czml-to-core branch June 13, 2021 12:24
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants