Skip to content
This repository has been archived by the owner on Oct 14, 2023. It is now read-only.

Move _check_altitude computation to core #1282

Merged
merged 1 commit into from
Jul 17, 2021

Conversation

Yash-10
Copy link
Member

@Yash-10 Yash-10 commented Jul 17, 2021

Moving computation for check_altitude to core. Fixes #1281.

Thanks!

Add core computation for check_altitude

reformat
@codecov
Copy link

codecov bot commented Jul 17, 2021

Codecov Report

Merging #1282 (7b8d7bc) into main (ea5bf1e) will increase coverage by 0.00%.
The diff coverage is 72.72%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1282   +/-   ##
=======================================
  Coverage   91.89%   91.90%           
=======================================
  Files          80       80           
  Lines        4196     4200    +4     
  Branches      360      360           
=======================================
+ Hits         3856     3860    +4     
  Misses        258      258           
  Partials       82       82           
Impacted Files Coverage Δ
src/poliastro/core/earth_atmosphere/util.py 74.19% <62.50%> (-4.07%) ⬇️
src/poliastro/earth/atmosphere/base.py 97.22% <100.00%> (+7.22%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ea5bf1e...7b8d7bc. Read the comment docs.

@astrojuanlu astrojuanlu merged commit e569eba into poliastro:main Jul 17, 2021
@Yash-10 Yash-10 deleted the check-altitude branch July 18, 2021 05:10
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move _check_altitude computation to poliastro.core
2 participants