Skip to content
This repository has been archived by the owner on Oct 14, 2023. It is now read-only.

Removed methods from plotting/util and twobody/orbit #1313

Merged
merged 1 commit into from
Aug 22, 2021
Merged

Removed methods from plotting/util and twobody/orbit #1313

merged 1 commit into from
Aug 22, 2021

Conversation

marwanhawari
Copy link
Contributor

Removed these dead methods:

  • Orbit._generate_time_values
  • poliastro.plotting.util.generate_circle

@codecov
Copy link

codecov bot commented Aug 22, 2021

Codecov Report

Merging #1313 (94f1d05) into main (3d0428b) will increase coverage by 0.21%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1313      +/-   ##
==========================================
+ Coverage   92.01%   92.22%   +0.21%     
==========================================
  Files          81       81              
  Lines        4256     4244      -12     
  Branches      358      357       -1     
==========================================
- Hits         3916     3914       -2     
+ Misses        258      248      -10     
  Partials       82       82              
Impacted Files Coverage Δ
src/poliastro/plotting/util.py 100.00% <ø> (+22.72%) ⬆️
src/poliastro/twobody/orbit.py 85.04% <ø> (+0.94%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3d0428b...94f1d05. Read the comment docs.

@astrojuanlu
Copy link
Member

Thanks for your contribution @marwanhawari !

@astrojuanlu astrojuanlu merged commit 2eb557c into poliastro:main Aug 22, 2021
@marwanhawari marwanhawari deleted the removed_methods branch August 22, 2021 11:23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants