Skip to content
This repository has been archived by the owner on Oct 14, 2023. It is now read-only.

Remove unused delta_inc #1344

Merged
merged 1 commit into from
Oct 15, 2021
Merged

Remove unused delta_inc #1344

merged 1 commit into from
Oct 15, 2021

Conversation

MLopez-Ibanez
Copy link
Contributor

No description provided.

Copy link
Member

@astrojuanlu astrojuanlu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @MLopez-Ibanez for your pull request! I think it's a good change, computing the inclination variation is trivial and we don't need to return it.

There is a problem with the docstring though, I see you're looking into it already.

@codecov
Copy link

codecov bot commented Oct 15, 2021

Codecov Report

Merging #1344 (5c86e9e) into main (7280a7d) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1344      +/-   ##
==========================================
- Coverage   92.34%   92.34%   -0.01%     
==========================================
  Files          81       81              
  Lines        4260     4259       -1     
  Branches      357      357              
==========================================
- Hits         3934     3933       -1     
  Misses        246      246              
  Partials       80       80              
Impacted Files Coverage Δ
src/poliastro/core/thrust/change_a_inc.py 100.00% <100.00%> (ø)
src/poliastro/twobody/thrust/change_a_inc.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7280a7d...5c86e9e. Read the comment docs.

@astrojuanlu astrojuanlu merged commit 02588df into poliastro:main Oct 15, 2021
@astrojuanlu
Copy link
Member

Thanks and congrats! 🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants