Skip to content
This repository has been archived by the owner on Oct 14, 2023. It is now read-only.

Fix #1343: Rename change_inc_ecc to change_ecc_inc #1346

Merged
merged 2 commits into from Oct 17, 2021

Conversation

MLopez-Ibanez
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Oct 16, 2021

Codecov Report

Merging #1346 (ee2709e) into main (02588df) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1346   +/-   ##
=======================================
  Coverage   92.34%   92.34%           
=======================================
  Files          81       81           
  Lines        4259     4259           
  Branches      357      357           
=======================================
  Hits         3933     3933           
  Misses        246      246           
  Partials       80       80           
Impacted Files Coverage Δ
src/poliastro/core/thrust/change_ecc_inc.py 100.00% <ø> (ø)
src/poliastro/twobody/thrust/__init__.py 100.00% <100.00%> (ø)
src/poliastro/twobody/thrust/change_ecc_inc.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 02588df...ee2709e. Read the comment docs.

@astrojuanlu
Copy link
Member

I think there's one rename missing, I see No module named 'poliastro.core.thrust.change_ecc_inc

Copy link
Member

@astrojuanlu astrojuanlu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks perfect now! 🎉 Merging when the tests pass

@astrojuanlu astrojuanlu merged commit d0a13af into poliastro:main Oct 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants