Skip to content
This repository has been archived by the owner on Oct 14, 2023. It is now read-only.

Fix #1360 vectorize rotation_matrix and fix axis=1 #1373

Merged
merged 1 commit into from Oct 31, 2021

Conversation

MLopez-Ibanez
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Oct 30, 2021

Codecov Report

Merging #1373 (5d2957f) into main (0e14e52) will decrease coverage by 58.69%.
The diff coverage is 0.00%.

❗ Current head 5d2957f differs from pull request most recent head 5cfd9f6. Consider uploading reports for the commit 5cfd9f6 to get more accurate results
Impacted file tree graph

@@             Coverage Diff             @@
##             main    #1373       +/-   ##
===========================================
- Coverage   92.42%   33.73%   -58.70%     
===========================================
  Files          82       82               
  Lines        4277     4281        +4     
  Branches      360      357        -3     
===========================================
- Hits         3953     1444     -2509     
- Misses        239     2831     +2592     
+ Partials       85        6       -79     
Impacted Files Coverage Δ
src/poliastro/core/util.py 26.82% <0.00%> (-62.36%) ⬇️
src/poliastro/core/propagation/__init__.py 10.00% <0.00%> (-86.00%) ⬇️
src/poliastro/threebody/restricted.py 18.60% <0.00%> (-81.40%) ⬇️
src/poliastro/core/maneuver.py 18.96% <0.00%> (-81.04%) ⬇️
src/poliastro/core/fixed.py 20.83% <0.00%> (-79.17%) ⬇️
src/poliastro/core/stumpff.py 21.21% <0.00%> (-78.79%) ⬇️
src/poliastro/core/earth_atmosphere/jacchia.py 19.81% <0.00%> (-78.38%) ⬇️
src/poliastro/core/elements.py 23.52% <0.00%> (-76.48%) ⬇️
src/poliastro/plotting/util.py 25.00% <0.00%> (-75.00%) ⬇️
src/poliastro/threebody/soi.py 25.00% <0.00%> (-75.00%) ⬇️
... and 55 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0e14e52...5cfd9f6. Read the comment docs.

@MLopez-Ibanez MLopez-Ibanez force-pushed the rotation_matrix branch 5 times, most recently from ea75958 to 2650667 Compare October 30, 2021 20:26
Copy link
Member

@astrojuanlu astrojuanlu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @MLopez-Ibanez !

@astrojuanlu astrojuanlu merged commit 37903a4 into poliastro:main Oct 31, 2021
@MLopez-Ibanez MLopez-Ibanez deleted the rotation_matrix branch October 31, 2021 09:48
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants