This repository was archived by the owner on Oct 14, 2023. It is now read-only.
Propagation improvements #140
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The callback is called at each internal integrator step, therefore enabling the user to retrieve every intermediate state.
Current coverage is 82.15% (diff: 100%)@@ master #140 diff @@
==========================================
Files 23 23
Lines 906 908 +2
Methods 0 0
Messages 0 0
Branches 71 72 +1
==========================================
+ Hits 740 746 +6
+ Misses 145 142 -3
+ Partials 21 20 -1
|
This leads to huge performance improvements, as `quantity_input` is very slow.
Still extremely slow.
One untouched test still failing
|
This PR has been standing for too long. Changes in plotting code can come later. |
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://github.com/poliastro/poliastro/wiki/Make-propagation-functions-higher-level for rationale.