-
-
Notifications
You must be signed in to change notification settings - Fork 283
Conversation
Trying to investigate the docs error... |
Codecov Report
@@ Coverage Diff @@
## main #1442 +/- ##
==========================================
- Coverage 91.93% 91.83% -0.10%
==========================================
Files 93 95 +2
Lines 4400 4448 +48
Branches 422 430 +8
==========================================
+ Hits 4045 4085 +40
- Misses 267 273 +6
- Partials 88 90 +2
Continue to review full report at Codecov.
|
It seems if the input array contains extra unwanted dimensions, it fails. (Maybe support to different types of norms, i.e. L1, L2, etc could also be kept just as in the case of |
I see that We want norms of vectors, not norm of matrices, so I think this failure is correct. It forces the user to put the vector in the correct shape though. Addmittedly, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks perfect to me! When we fix the notebook that is failing, we can merge.
Add fast norm reformat c d change
Thanks a lot @Yash-10 ! |
From observations in #1433.
Thanks!