Skip to content
This repository has been archived by the owner on Oct 14, 2023. It is now read-only.

Revert smarter E and H estimates #1444

Merged
merged 2 commits into from
Jan 18, 2022
Merged

Conversation

Yash-10
Copy link
Member

@Yash-10 Yash-10 commented Jan 18, 2022

Bug observed in #1296 was due to changes done in #1247.

@Yash-10 Yash-10 force-pushed the revert-pr-1214 branch 2 times, most recently from fa8717c to e44ebde Compare January 18, 2022 16:11
Copy link
Member

@astrojuanlu astrojuanlu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me except for the failing test!

tests/tests_twobody/test_propagation.py Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Jan 18, 2022

Codecov Report

Merging #1444 (e44ebde) into main (93f9fab) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head e44ebde differs from pull request most recent head 545f7e2. Consider uploading reports for the commit 545f7e2 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1444      +/-   ##
==========================================
- Coverage   91.83%   91.83%   -0.01%     
==========================================
  Files          95       95              
  Lines        4448     4444       -4     
  Branches      430      427       -3     
==========================================
- Hits         4085     4081       -4     
  Misses        273      273              
  Partials       90       90              
Impacted Files Coverage Δ
src/poliastro/core/angles.py 95.29% <100.00%> (-0.32%) ⬇️
src/poliastro/bodies.py 85.71% <0.00%> (+0.52%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 93f9fab...545f7e2. Read the comment docs.

@astrojuanlu astrojuanlu merged commit 185a01b into poliastro:main Jan 18, 2022
@astrojuanlu
Copy link
Member

Thanks a lot @Yash-10 !

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants