This repository was archived by the owner on Oct 14, 2023. It is now read-only.
Revert smarter E and H estimates#1444
Merged
astrojuanlu merged 2 commits intopoliastro:mainfrom Jan 18, 2022
Merged
Conversation
Yash-10
force-pushed
the
revert-pr-1214
branch
2 times, most recently
from
fa8717c to
e44ebde
Compare
astrojuanlu
reviewed
Jan 18, 2022
Member
astrojuanlu
left a comment
astrojuanlu
left a comment
There was a problem hiding this comment.
Looks good to me except for the failing test!
Codecov Report
@@ Coverage Diff @@
## main #1444 +/- ##
==========================================
- Coverage 91.83% 91.83% -0.01%
==========================================
Files 95 95
Lines 4448 4444 -4
Branches 430 427 -3
==========================================
- Hits 4085 4081 -4
Misses 273 273
Partials 90 90
Continue to review full report at Codecov.
|
Yash-10
force-pushed
the
revert-pr-1214
branch
from
e44ebde to
545f7e2
Compare
Member
|
Thanks a lot @Yash-10 ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug observed in #1296 was due to changes done in #1247.