Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor plotting #528

Merged
merged 23 commits into from Jan 7, 2019

Conversation

Projects
None yet
1 participant
@Juanlu001
Copy link
Member

commented Jan 4, 2019

Implements the ideas outlined in https://github.com/poliastro/poliastro/wiki/Plotting after discussion in #338 and lots of back and forth. Can be considered an improved (but different) version of #481.

Several issues and tasks remain:

  • #518
  • #483
  • Redrawing the attractor doesn't erase previously drawn data
  • Orbit.plot
  • Re-running notebooks
  • Documentation

And some minor things:

  • Hover works weird in 2D
  • Autoscaling requires redundant data in 2D

So far this was 80 % of the work. The remainders are the 80 % of the time 馃榿

Juanlu001 added some commits Jan 4, 2019

Split plotting module in submodules
Fix #338.

* Rename OrbitPlotter to StaticOrbitPlotter
* Only expose OrbitPlotter2D/3D in poliastro.plotting
* Make plot_solar_system use OrbitPlotter2D/3D
* Split tests

Some tests failing.
Refactor OrbitPlotter3D
Fix #460.

Already works with a given figure.
Tracking of existing trajectories still missing, and
corresponding tests failing.
Add set_frame to OrbitPlotter2D
Fix #480
Some issues remain.

@Juanlu001 Juanlu001 force-pushed the Juanlu001:refactor-plotting branch from fec337b to d66b9bf Jan 7, 2019

@codecov

This comment has been minimized.

Copy link

commented Jan 7, 2019

Codecov Report

Merging #528 into master will decrease coverage by 0.07%.
The diff coverage is 89.11%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #528      +/-   ##
==========================================
- Coverage   86.13%   86.06%   -0.08%     
==========================================
  Files          46       51       +5     
  Lines        2207     2282      +75     
  Branches      173      182       +9     
==========================================
+ Hits         1901     1964      +63     
- Misses        265      271       +6     
- Partials       41       47       +6
Impacted Files Coverage 螖
src/poliastro/plotting/misc.py 100% <100%> (酶)
src/poliastro/plotting/__init__.py 100% <100%> (酶)
src/poliastro/twobody/orbit.py 88.57% <40%> (-1.19%) 猬囷笍
src/poliastro/plotting/util.py 78.26% <78.26%> (酶)
src/poliastro/plotting/static.py 87.37% <87.37%> (酶)
src/poliastro/plotting/core.py 91.66% <91.66%> (酶)
src/poliastro/plotting/_base.py 93.15% <93.15%> (酶)
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update e602d21...0cd1262. Read the comment docs.

@Juanlu001 Juanlu001 force-pushed the Juanlu001:refactor-plotting branch from d66b9bf to 92344a1 Jan 7, 2019

@Juanlu001 Juanlu001 force-pushed the Juanlu001:refactor-plotting branch from 92344a1 to 83a1367 Jan 7, 2019

@Juanlu001 Juanlu001 force-pushed the Juanlu001:refactor-plotting branch 2 times, most recently from e01004a to a583b3f Jan 7, 2019

@Juanlu001 Juanlu001 force-pushed the Juanlu001:refactor-plotting branch from a583b3f to 260a751 Jan 7, 2019

Fix docs
Is not there a better way?

@Juanlu001 Juanlu001 changed the title WIP: Refactor plotting Refactor plotting Jan 7, 2019

@Juanlu001

This comment has been minimized.

Copy link
Member Author

commented Jan 7, 2019

This pull request fixes a lot of plotting issues and is long enough already, so even if I could work on the docs a bit more, I prefer to merge it now, to let others use this new code and discover issues.

@Juanlu001 Juanlu001 merged commit 27a49be into poliastro:master Jan 7, 2019

11 checks passed

ci/circleci: coverage Your tests passed on CircleCI!
Details
ci/circleci: docs Your tests passed on CircleCI!
Details
ci/circleci: quality Your tests passed on CircleCI!
Details
ci/circleci: test_py35 Your tests passed on CircleCI!
Details
ci/circleci: test_py36 Your tests passed on CircleCI!
Details
ci/circleci: test_py37 Your tests passed on CircleCI!
Details
codeclimate Approved by Juan Luis Cano Rodr铆guez.
Details
codecov/patch 89.11% of diff hit (target 86.13%)
Details
codecov/project Absolute coverage decreased by -0.07% but relative coverage increased by +2.98% compared to e602d21
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@wafflebot wafflebot bot removed the 2 - In Progress label Jan 7, 2019

@Juanlu001 Juanlu001 deleted the Juanlu001:refactor-plotting branch Jan 7, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can鈥檛 perform that action at this time.