Skip to content
This repository has been archived by the owner on Oct 14, 2023. It is now read-only.

Refactor State class #61

merged 12 commits into from Jul 3, 2015


Copy link

This allows for adding new representations in an easier way (see #17).

Inspired by the work done in scipy.signal.ltisys by Felix Berkenkamp
The conversion is made transitive and non singular through
the use of semilatus rectum instead of semimajor axis, see poliastro#62.
The case of polar inclination is still pending.
Using semilatus rectum instead of semimajor axis improves stability
of the algorithms. Also, it helps making conversion transitive.
Closes poliastro#62.
Some pending issues:
* Name clash between specific angular momentum and fourth mee.
* Conversion between rv and mee.
* Tests pending, did not find numerical examples.
* Split code into files? is already over 500 lines.
h still can be calculated using the norm of h_vec, while I avoid a name clash.
Also added dummy conversion functions.
@astrojuanlu astrojuanlu changed the title [WIP] Refactor State class Refactor State class Jul 3, 2015
Copy link
Member Author

There are some conversion functions missing but I will leave it as it is now. Lack of numerical examples to provide tests don't motivate me to add them, I will leave an issue open about it. This will probably mean a decrease in coverage.

astrojuanlu added a commit that referenced this pull request Jul 3, 2015
Refactor `State` class, added modified equinoctial elements, closes #17.
@astrojuanlu astrojuanlu merged commit a2bba52 into poliastro:master Jul 3, 2015
@astrojuanlu astrojuanlu deleted the refactor-state#17 branch July 3, 2015 09:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

1 participant