New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor `State` class #61

Merged
merged 12 commits into from Jul 3, 2015

Conversation

1 participant
@Juanlu001
Member

Juanlu001 commented Jul 1, 2015

This allows for adding new representations in an easier way (see #17).

Juanlu001 added some commits Jul 1, 2015

Refactored State class, added subclasses
Inspired by the work done in scipy.signal.ltisys by Felix Berkenkamp

Juanlu001 added some commits Jul 2, 2015

Added conversion between coe and mee
The conversion is made transitive and non singular through
the use of semilatus rectum instead of semimajor axis, see #62.
The case of polar inclination is still pending.
Changed shape parameter from a to p
Using semilatus rectum instead of semimajor axis improves stability
of the algorithms. Also, it helps making conversion transitive.
Closes #62.
WIP: Added _ModifiedEquinoctialState class
Some pending issues:
* Name clash between specific angular momentum and fourth mee.
* Conversion between rv and mee.
* Tests pending, did not find numerical examples.
* Split code into files? state.py is already over 500 lines.
Replaced specific angular momentum with specific energy
h still can be calculated using the norm of h_vec, while I avoid a name clash.
Added modified equinoctial elements properties
Also added dummy conversion functions.

@Juanlu001 Juanlu001 changed the title from [WIP] Refactor `State` class to Refactor `State` class Jul 3, 2015

@Juanlu001

This comment has been minimized.

Member

Juanlu001 commented Jul 3, 2015

There are some conversion functions missing but I will leave it as it is now. Lack of numerical examples to provide tests don't motivate me to add them, I will leave an issue open about it. This will probably mean a decrease in coverage.

Juanlu001 added a commit that referenced this pull request Jul 3, 2015

Merge pull request #61 from Juanlu001/refactor-state#17
Refactor `State` class, added modified equinoctial elements, closes #17.

@Juanlu001 Juanlu001 merged commit a2bba52 into poliastro:master Jul 3, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@Juanlu001 Juanlu001 deleted the Juanlu001:refactor-state#17 branch Jul 3, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment