Refactor `State` class #61
Merged
Conversation
Inspired by the work done in scipy.signal.ltisys by Felix Berkenkamp
The conversion is made transitive and non singular through the use of semilatus rectum instead of semimajor axis, see #62. The case of polar inclination is still pending.
Using semilatus rectum instead of semimajor axis improves stability of the algorithms. Also, it helps making conversion transitive. Closes #62.
Some pending issues: * Name clash between specific angular momentum and fourth mee. * Conversion between rv and mee. * Tests pending, did not find numerical examples. * Split code into files? state.py is already over 500 lines.
h still can be calculated using the norm of h_vec, while I avoid a name clash.
Also added dummy conversion functions.
|
There are some conversion functions missing but I will leave it as it is now. Lack of numerical examples to provide tests don't motivate me to add them, I will leave an issue open about it. This will probably mean a decrease in coverage. |
astrojuanlu
added a commit
that referenced
this pull request
Jul 3, 2015
Refactor `State` class, added modified equinoctial elements, closes #17.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
This allows for adding new representations in an easier way (see #17).