Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor `State` class #61

Merged
merged 12 commits into from Jul 3, 2015
Merged

Conversation

@astrojuanlu
Copy link
Member

@astrojuanlu astrojuanlu commented Jul 1, 2015

This allows for adding new representations in an easier way (see #17).

astrojuanlu added 2 commits Jul 1, 2015
Inspired by the work done in scipy.signal.ltisys by Felix Berkenkamp
astrojuanlu added 9 commits Jul 2, 2015
The conversion is made transitive and non singular through
the use of semilatus rectum instead of semimajor axis, see #62.
The case of polar inclination is still pending.
Using semilatus rectum instead of semimajor axis improves stability
of the algorithms. Also, it helps making conversion transitive.
Closes #62.
Some pending issues:
* Name clash between specific angular momentum and fourth mee.
* Conversion between rv and mee.
* Tests pending, did not find numerical examples.
* Split code into files? state.py is already over 500 lines.
h still can be calculated using the norm of h_vec, while I avoid a name clash.
Also added dummy conversion functions.
@astrojuanlu astrojuanlu changed the title [WIP] Refactor `State` class Refactor `State` class Jul 3, 2015
@astrojuanlu
Copy link
Member Author

@astrojuanlu astrojuanlu commented Jul 3, 2015

There are some conversion functions missing but I will leave it as it is now. Lack of numerical examples to provide tests don't motivate me to add them, I will leave an issue open about it. This will probably mean a decrease in coverage.

astrojuanlu added a commit that referenced this pull request Jul 3, 2015
Refactor `State` class, added modified equinoctial elements, closes #17.
@astrojuanlu astrojuanlu merged commit a2bba52 into poliastro:master Jul 3, 2015
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@astrojuanlu astrojuanlu deleted the astrojuanlu:refactor-state#17 branch Jul 3, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant