Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update user's guide to new Lambert maneuvers #699

Merged
merged 3 commits into from Jun 17, 2019

Conversation

@jorgepiloto
Copy link
Member

jorgepiloto commented Jun 11, 2019

This tries to update the user's guide and also the different notebooks that make use of the Lambert algorithm, so they can be consistent with the new nature of Maneuver.lambert.

I still need to update the Going to Mars example.

Just decided to start the PR for the reviewing process 馃憤

Copy link
Member

Juanlu001 left a comment

So far so good!

@Juanlu001

This comment has been minimized.

Copy link
Member

Juanlu001 commented Jun 11, 2019

Tests failing because of #665

@jorgepiloto jorgepiloto force-pushed the jorgepiloto:lambert branch from c082663 to da4876e Jun 14, 2019
@jorgepiloto

This comment has been minimized.

Copy link
Member Author

jorgepiloto commented Jun 14, 2019

I simplified Mars' notebook by making use of from_body_epehem constructor and the sample method. However, you better tell me if it looks good or something needs to be changed 馃憤

@codecov

This comment has been minimized.

Copy link

codecov bot commented Jun 14, 2019

Codecov Report

Merging #699 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #699   +/-   ##
=======================================
  Coverage   87.21%   87.21%           
=======================================
  Files          53       53           
  Lines        2676     2676           
  Branches      236      236           
=======================================
  Hits         2334     2334           
  Misses        267      267           
  Partials       75       75

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 7c63b9c...e86f5f9. Read the comment docs.

@jorgepiloto jorgepiloto force-pushed the jorgepiloto:lambert branch from da4876e to e86f5f9 Jun 15, 2019
@Juanlu001 Juanlu001 merged commit 2cca545 into poliastro:master Jun 17, 2019
10 checks passed
10 checks passed
ci/circleci: coverage Your tests passed on CircleCI!
Details
ci/circleci: docs Your tests passed on CircleCI!
Details
ci/circleci: quality Your tests passed on CircleCI!
Details
ci/circleci: test_py35 Your tests passed on CircleCI!
Details
ci/circleci: test_py36 Your tests passed on CircleCI!
Details
ci/circleci: test_py37 Your tests passed on CircleCI!
Details
codeclimate All good!
Details
codecov/patch Coverage not affected when comparing 7c63b9c...e86f5f9
Details
codecov/project 87.21% remains the same compared to 7c63b9c
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
@Juanlu001

This comment has been minimized.

Copy link
Member

Juanlu001 commented Jun 17, 2019

Thanks a lot @jorgepiloto!

@jorgepiloto jorgepiloto deleted the jorgepiloto:lambert branch Jul 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can鈥檛 perform that action at this time.