Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Izzo algorithm logic #709

Merged
merged 4 commits into from Jun 22, 2019
Merged

Fix Izzo algorithm logic #709

merged 4 commits into from Jun 22, 2019

Conversation

@Juanlu001
Copy link
Member

Juanlu001 commented Jun 22, 2019

Fix #348 by adding time-of-flight equation that does not need external computation of one of the terms. See the issue, and in particular #348 (comment), for rationale.

@jorgepiloto your task is to write a unit test that fails with master and passes in this branch 馃槈

jorgepiloto and others added 3 commits Jun 22, 2019
Add Izzo test and update Revisiting Lambert's notebook
@codecov

This comment has been minimized.

Copy link

codecov bot commented Jun 22, 2019

Codecov Report

Merging #709 into master will increase coverage by <.01%.
The diff coverage is 85.71%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #709      +/-   ##
==========================================
+ Coverage   87.43%   87.44%   +<.01%     
==========================================
  Files          53       53              
  Lines        2699     2700       +1     
  Branches      241      241              
==========================================
+ Hits         2360     2361       +1     
  Misses        265      265              
  Partials       74       74
Impacted Files Coverage 螖
src/poliastro/core/iod.py 88.69% <85.71%> (+0.06%) 猬嗭笍

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update c9afdc9...3ab05f6. Read the comment docs.

@Juanlu001 Juanlu001 merged commit 233a89c into poliastro:master Jun 22, 2019
9 of 10 checks passed
9 of 10 checks passed
codecov/patch 85.71% of diff hit (target 87.43%)
Details
ci/circleci: coverage Your tests passed on CircleCI!
Details
ci/circleci: docs Your tests passed on CircleCI!
Details
ci/circleci: quality Your tests passed on CircleCI!
Details
ci/circleci: test_py35 Your tests passed on CircleCI!
Details
ci/circleci: test_py36 Your tests passed on CircleCI!
Details
ci/circleci: test_py37 Your tests passed on CircleCI!
Details
codeclimate All good!
Details
codecov/project 87.44% (+<.01%) compared to c9afdc9
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
@Juanlu001 Juanlu001 deleted the Juanlu001:fix-izzo branch Jun 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants
You can鈥檛 perform that action at this time.