Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor orbit plotters #876

Merged
merged 21 commits into from Mar 22, 2020

Conversation

astrojuanlu
Copy link
Member

@astrojuanlu astrojuanlu commented Mar 22, 2020

We had accumulated a lot of technical debt with the plotting code and this PR tries to refactor some stuff to unify the Plotly-based with the matplotlib-based code.

Still room for improvement, I might tweak this a bit further today.

@astrojuanlu astrojuanlu force-pushed the refactor-orbit-plotters branch 4 times, most recently from 1da93b7 to dd9a414 Compare Mar 22, 2020
@astrojuanlu
Copy link
Member Author

astrojuanlu commented Mar 22, 2020

Enough with the refactor for today. There's one key feature missing in OrbitPlotter2D, which is redrawing. For the purposes of this PR, I will focus on fixing the tests and getting it merged.

@astrojuanlu
Copy link
Member Author

astrojuanlu commented Mar 22, 2020

Blessed image tests 😍

@astrojuanlu astrojuanlu merged commit cfe8daa into poliastro:master Mar 22, 2020
13 checks passed
@astrojuanlu astrojuanlu deleted the refactor-orbit-plotters branch Mar 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant