Skip to content
This repository has been archived by the owner on Oct 14, 2023. It is now read-only.

Refactor orbit plotters #876

Merged
merged 21 commits into from
Mar 22, 2020

Conversation

astrojuanlu
Copy link
Member

We had accumulated a lot of technical debt with the plotting code and this PR tries to refactor some stuff to unify the Plotly-based with the matplotlib-based code.

Still room for improvement, I might tweak this a bit further today.

@astrojuanlu astrojuanlu force-pushed the refactor-orbit-plotters branch from f526a4c to a75afbb Compare March 22, 2020 12:36
@astrojuanlu astrojuanlu force-pushed the refactor-orbit-plotters branch 4 times, most recently from 1da93b7 to dd9a414 Compare March 22, 2020 18:08
@astrojuanlu
Copy link
Member Author

Enough with the refactor for today. There's one key feature missing in OrbitPlotter2D, which is redrawing. For the purposes of this PR, I will focus on fixing the tests and getting it merged.

@astrojuanlu
Copy link
Member Author

Blessed image tests 😍

@astrojuanlu astrojuanlu force-pushed the refactor-orbit-plotters branch from 820363c to efe2143 Compare March 22, 2020 20:03
@astrojuanlu astrojuanlu merged commit cfe8daa into poliastro:master Mar 22, 2020
@astrojuanlu astrojuanlu deleted the refactor-orbit-plotters branch March 22, 2020 20:46
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant