This repository has been archived by the owner on Oct 14, 2023. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 285
Refactor orbit plotters #876
Merged
astrojuanlu
merged 21 commits into
poliastro:master
from
astrojuanlu:refactor-orbit-plotters
Mar 22, 2020
Merged
Refactor orbit plotters #876
astrojuanlu
merged 21 commits into
poliastro:master
from
astrojuanlu:refactor-orbit-plotters
Mar 22, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f526a4c
to
a75afbb
Compare
6 tasks
1da93b7
to
dd9a414
Compare
Enough with the refactor for today. There's one key feature missing in |
Blessed image tests 😍 |
OrbitPlotter2D does not support redrawing yet.
Hidden bug!
820363c
to
efe2143
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had accumulated a lot of technical debt with the plotting code and this PR tries to refactor some stuff to unify the Plotly-based with the matplotlib-based code.
Still room for improvement, I might tweak this a bit further today.