This repository was archived by the owner on Oct 14, 2023. It is now read-only.
Refactor orbit plotters - #876
Merged
astrojuanlu merged 21 commits intoMar 22, 2020
Merged
Conversation
astrojuanlu
force-pushed
the
refactor-orbit-plotters
branch
from
March 22, 2020 12:36
f526a4c to
a75afbb
Compare
6 tasks
astrojuanlu
force-pushed
the
refactor-orbit-plotters
branch
4 times, most recently
from
March 22, 2020 18:08
1da93b7 to
dd9a414
Compare
Member
Author
|
Enough with the refactor for today. There's one key feature missing in |
Member
Author
|
Blessed image tests 😍 |
OrbitPlotter2D does not support redrawing yet.
Hidden bug!
astrojuanlu
force-pushed
the
refactor-orbit-plotters
branch
from
March 22, 2020 20:03
820363c to
efe2143
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We had accumulated a lot of technical debt with the plotting code and this PR tries to refactor some stuff to unify the Plotly-based with the matplotlib-based code.
Still room for improvement, I might tweak this a bit further today.