Running example in production SS_ENV throws #4

Closed
casio opened this Issue Oct 9, 2012 · 3 comments

Comments

Projects
None yet
3 participants
@casio

casio commented Oct 9, 2012

When running the example like so: SS_ENV=production node app.js,
you get the following excpetion in the browser Unknown provider: e from exampleApp.

I assume thats an issue related to the uglifyjs renaming passes & understand ss-angular maybe isnt production-ready, yet.

But do you maybe have an idea where this might be located? Maybe fixing it is just using array notation for some name.

@polidore

This comment has been minimized.

Show comment
Hide comment
@polidore

polidore Nov 2, 2012

Owner

this is fixed in 0.4.14. I wasn't using the array syntax that you need for minification in angular.

Owner

polidore commented Nov 2, 2012

this is fixed in 0.4.14. I wasn't using the array syntax that you need for minification in angular.

@polidore polidore closed this Nov 2, 2012

@jgebhardt

This comment has been minimized.

Show comment
Hide comment
@jgebhardt

jgebhardt Nov 17, 2012

Hi Benjamin,

I've been facing the same issue and unfortunately it still does not work for me in 0.5.1. Just did a clean pull and ran
SS_ENV=production SS_PACK=1 node app.js

Any ideas? Thanks.

Hi Benjamin,

I've been facing the same issue and unfortunately it still does not work for me in 0.5.1. Just did a clean pull and ran
SS_ENV=production SS_PACK=1 node app.js

Any ideas? Thanks.

@polidore

This comment has been minimized.

Show comment
Hide comment
@polidore

polidore Nov 26, 2012

Owner

ok, now it's really fixed. sorry about that.

Owner

polidore commented Nov 26, 2012

ok, now it's really fixed. sorry about that.

polidore pushed a commit that referenced this issue Nov 26, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment