Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix (#5): Reference computed Vue CLI Webpack config, when available, for import aliases #6

Merged
merged 1 commit into from Jan 7, 2020

Conversation

@jackkoppa
Copy link
Member

jackkoppa commented Jan 7, 2020

No description provided.

* we'll likely want to add a test for this and other methods to retrieve those aliases
* For now, it's not worth the effort to setup & maintain an entire dummy Vue CLI project,
* with the relevant vue.config.js
*/

This comment has been minimized.

Copy link
@jackkoppa

jackkoppa Jan 7, 2020

Author Member

Intentionally skipped tests for this case, for now. The proper test would be to initialize a sample Vue CLI project within this repo, and have it import at least one aliased file. Given that the failure is graceful, the overhead of maintaining a CLI project in this repo does not yet seem worth it, though it can certainly be done at some point.

@jackkoppa jackkoppa merged commit 90a80c2 into master Jan 7, 2020
@jackkoppa jackkoppa deleted the fix/alias-import-resolution branch Jan 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant
You can’t perform that action at this time.