New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add project dependencies #2

Merged
merged 1 commit into from Sep 18, 2018

Conversation

Projects
None yet
4 participants
@accua
Collaborator

accua commented Sep 12, 2018

  • Adds HTTP client httpoison
  • JSON lib poison
  • ex_doc for doc generation
  • mix_test_watch runs tests each time you save, good for TDD.
Add project dependencies
- Adds HTTP client httpoison
- JSON lib poison
- ex_doc for doc generation
- mix_test_watch runs tests each time you save, good for TDD.

@accua accua self-assigned this Sep 12, 2018

@accua accua added the enhancement label Sep 12, 2018

@accua accua requested a review from ckrailo Sep 12, 2018

@@ -21,8 +21,10 @@ defmodule Politex.MixProject do
# Run "mix help deps" to learn about dependencies.
defp deps do
[
# {:dep_from_hexpm, "~> 0.3.0"},
# {:dep_from_git, git: "https://github.com/elixir-lang/my_dep.git", tag: "0.1.0"},
{:httpoison, "~> 1.3.0"},

This comment has been minimized.

@doughsay

doughsay Sep 16, 2018

Have you considered other HTTP clients? httpoison is definitely the most popular, but it's architected more like httparty from Ruby-land. If you want something more like Faraday from Ruby-land, consider checking out tesla. I've been using it in production and like the middleware architecture it uses.

This comment has been minimized.

@bzitzow

This comment has been minimized.

@ckrailo

ckrailo Sep 17, 2018

Contributor

Great recommendations, thanks! These were originally chosen from off-the-cuff recommendations during a lunch chat with McCord, but we're not opposed to using different stuff. ¯\_(ツ)_/¯

# {:dep_from_hexpm, "~> 0.3.0"},
# {:dep_from_git, git: "https://github.com/elixir-lang/my_dep.git", tag: "0.1.0"},
{:httpoison, "~> 1.3.0"},
{:poison, "~> 4.0.1"},

This comment has been minimized.

@doughsay

doughsay Sep 16, 2018

The community is largely moving to jason. It's faster than poison, and many projects have jumped ship already. I'd recommend using it from the start.

This comment has been minimized.

@bzitzow
@ckrailo

This comment has been minimized.

Contributor

ckrailo commented Sep 18, 2018

Merging this! We should look into Tesla and either switch or at least make a branch that implements Tesla just to work with it.

@ckrailo ckrailo merged commit 526fa69 into master Sep 18, 2018

@ckrailo ckrailo deleted the add_deps branch Sep 18, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment