-
Notifications
You must be signed in to change notification settings - Fork 71
Dark mode images fix #1110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dark mode images fix #1110
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR addresses dark mode compatibility issues by removing white background fills from Mermaid diagrams and adding proper background styling to images that may not display well in dark mode.
- Updates Mermaid diagram styles to remove hard-coded white fill colors that cause visibility issues in dark mode
- Adds white background styling to images that need proper contrast in dark mode
- Regenerates AI-generated files to reflect the styling changes
Reviewed Changes
Copilot reviewed 19 out of 20 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| polkadot-protocol/smart-contract-basics/overview.md | Removes white fill from Mermaid diagram style attributes |
| polkadot-protocol/parachain-basics/blocks-transactions-fees/transactions.md | Adds white background styling to transaction lifecycle diagram |
| polkadot-protocol/architecture/polkadot-chain/overview.md | Adds white background styling to Polkadot architecture overview image |
| develop/smart-contracts/precompiles/index.md | Removes unused classDef styling from Mermaid diagram |
| develop/parachains/deployment/index.md | Removes white fill from deployment flowchart style attributes |
| develop/parachains/customize-parachain/overview.md | Adds white background and padding styling to FRAME overview image |
| llms-full.jsonl | Updates AI training data to reflect the styling changes |
| .ai/* | Regenerated AI files reflecting the updated content and styling changes |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
π Description
This PR addresses some image and Mermaid diagram issues in dark mode.
π Review Preference
Choose one:
π€ AI-Ready Docs
If content changed, regenerate AI files:
python3 scripts/generate_llms.pyβ Checklist