Skip to content

Conversation

@0xlukem
Copy link
Contributor

@0xlukem 0xlukem commented Oct 15, 2025

πŸ“ Description

This PR addresses some image and Mermaid diagram issues in dark mode.

πŸ” Review Preference

Choose one:

  • βœ… I have time to handle formatting/style feedback myself
  • ⚑ Docs team handles formatting (check "Allow edits from maintainers")

πŸ€– AI-Ready Docs

If content changed, regenerate AI files:

  • βœ… I ran python3 scripts/generate_llms.py
  • ⚑ Docs team will regenerate (check "Allow edits from maintainers")

βœ… Checklist

Copilot AI review requested due to automatic review settings October 15, 2025 20:25
@0xlukem 0xlukem requested a review from a team as a code owner October 15, 2025 20:25
@0xlukem 0xlukem added B0 - Needs Review Pull request is ready for review A2 - Maintenance Minor Pull request contains minor updates to an existing page (i.e., modifying parameters, steps, etc.) labels Oct 15, 2025
@0xlukem 0xlukem changed the title 0xlukem/dark mode fix Dark mode images fix Oct 15, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR addresses dark mode compatibility issues by removing white background fills from Mermaid diagrams and adding proper background styling to images that may not display well in dark mode.

  • Updates Mermaid diagram styles to remove hard-coded white fill colors that cause visibility issues in dark mode
  • Adds white background styling to images that need proper contrast in dark mode
  • Regenerates AI-generated files to reflect the styling changes

Reviewed Changes

Copilot reviewed 19 out of 20 changed files in this pull request and generated no comments.

Show a summary per file
File Description
polkadot-protocol/smart-contract-basics/overview.md Removes white fill from Mermaid diagram style attributes
polkadot-protocol/parachain-basics/blocks-transactions-fees/transactions.md Adds white background styling to transaction lifecycle diagram
polkadot-protocol/architecture/polkadot-chain/overview.md Adds white background styling to Polkadot architecture overview image
develop/smart-contracts/precompiles/index.md Removes unused classDef styling from Mermaid diagram
develop/parachains/deployment/index.md Removes white fill from deployment flowchart style attributes
develop/parachains/customize-parachain/overview.md Adds white background and padding styling to FRAME overview image
llms-full.jsonl Updates AI training data to reflect the styling changes
.ai/* Regenerated AI files reflecting the updated content and styling changes

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@eshaben eshaben added B1 - Ready to Merge Pull request is ready to be merged and removed B0 - Needs Review Pull request is ready for review labels Oct 16, 2025
@eshaben eshaben merged commit d3e0354 into master Oct 16, 2025
8 of 12 checks passed
@eshaben eshaben deleted the 0xlukem/dark-mode-fix branch October 16, 2025 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A2 - Maintenance Minor Pull request contains minor updates to an existing page (i.e., modifying parameters, steps, etc.) B1 - Ready to Merge Pull request is ready to be merged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants