Skip to content

Conversation

@dawnkelly09
Copy link
Collaborator

📝 Description

Provide a clear and concise description of your changes.

Patches script to remove excess checks and processing of urls that were triggering confusing failed errors even though UI was working.

🔍 Review Preference

Choose one:

  • ✅ I have time to handle formatting/style feedback myself
  • ⚡ Docs team handles formatting (check "Allow edits from maintainers")

🤖 AI-Ready Docs

If content changed, regenerate AI files:

  • ✅ I ran python3 scripts/generate_llms.py
  • ⚡ Docs team will regenerate (check "Allow edits from maintainers")

✅ Checklist

@dawnkelly09 dawnkelly09 added B0 - Needs Review Pull request is ready for review A2 - Maintenance Minor Pull request contains minor updates to an existing page (i.e., modifying parameters, steps, etc.) labels Oct 22, 2025
@dawnkelly09 dawnkelly09 requested a review from eshaben October 22, 2025 19:08
@dawnkelly09 dawnkelly09 marked this pull request as ready for review October 22, 2025 19:11
@dawnkelly09 dawnkelly09 requested a review from a team as a code owner October 22, 2025 19:11
Copilot AI review requested due to automatic review settings October 22, 2025 19:11
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR simplifies the "Copy to LLM" widget by removing complex configuration loading and URL candidate logic. Instead of fetching configuration from llms_config.json and checking multiple URL patterns, the script now uses a single, hardcoded path pattern (/ai/pages/{slug}.md) to locate markdown files.

Key Changes:

  • Removed configuration loading system (loadConfig, ready, computeRemoteBase)
  • Simplified markdown fetching to use a single URL pattern instead of multiple candidates
  • Removed HTML content fallback when markdown fetch fails

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Copy link
Collaborator

@eshaben eshaben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Great job!

@eshaben eshaben requested a review from Copilot October 22, 2025 21:10
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 3 comments.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@eshaben eshaben requested a review from Copilot October 22, 2025 21:29
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@kapetan3sid kapetan3sid assigned eshaben and unassigned eshaben Oct 23, 2025
@dawnkelly09 dawnkelly09 requested a review from eshaben October 23, 2025 14:00
@eshaben eshaben requested a review from Copilot October 23, 2025 14:54
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@eshaben eshaben requested a review from Copilot October 23, 2025 15:32
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 2 comments.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Copy link
Collaborator

@eshaben eshaben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

Copy link
Contributor

@0xlukem 0xlukem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@0xlukem 0xlukem removed the B0 - Needs Review Pull request is ready for review label Oct 23, 2025
@eshaben eshaben added the B1 - Ready to Merge Pull request is ready to be merged label Oct 23, 2025
@eshaben eshaben merged commit 413bf75 into master Oct 23, 2025
4 of 6 checks passed
@eshaben eshaben deleted the dawn/patch_llm-script branch October 23, 2025 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A2 - Maintenance Minor Pull request contains minor updates to an existing page (i.e., modifying parameters, steps, etc.) B1 - Ready to Merge Pull request is ready to be merged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants