Swap to Mortal transactions by default #1081
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
jacogr
commented
Jul 8, 2019
•
jacogr
commented
- signAndSend will retrieve the block (unless era or eraLength is specified)
- eraLength is new - setting this to -1 indicated immortal, otherwise it is the length in blocks (defaults to 10)
- I don't like the code that returns the nonce and signedBlock, so suggestions welcome
amaury1093
reviewed
Jul 8, 2019
|
Blocked on #1082 - sadly cannot actually do e2e tests here at all since all the indexes are off and it may or may not be operational. EDIT: Merged above, updated e2e tests (and resurrected SignedBlock), does the correct thing byte-wise for both mortal and immortals. |
amaury1093
approved these changes
Jul 9, 2019
docs/examples/promise/07_make_transfer_with_allowed_block_permissions_only/index.js
Outdated
Show resolved
Hide resolved
docs/examples/promise/07_make_transfer_with_allowed_block_permissions_only/index.js
Outdated
Show resolved
Hide resolved
| @@ -76,11 +85,11 @@ export interface SubmittableExtrinsic<ApiType> extends IExtrinsic { | |||
|
|
|||
| sign (account: IKeyringPair, _options: Partial<SignatureOptions>): this; | |||
|
|
|||
| signAndSend (account: IKeyringPair | string | AccountId | Address, options?: Partial<SignatureOptions>): SumbitableResultResult<ApiType>; | |||
| signAndSend (account: IKeyringPair | string | AccountId | Address, options?: Partial<SignerOptions>): SumbitableResultResult<ApiType>; | |||
There was a problem hiding this comment.
Two lines above it's still SignatureOptions, I guess SignerOptions is more flexible there too
There was a problem hiding this comment.
Yes, cannot quite change the sign signature, which is a muck-up - since that sits in IExtrinsic. Had it changed and then it complains bitterly.
There was a problem hiding this comment.
Ah i see what you mean, ok
docs/examples/promise/07_make_transfer_with_allowed_block_permissions_only/index.js
Outdated
Show resolved
Hide resolved
…issions_only/index.js Co-Authored-By: Amaury Martiny <amaury.martiny@protonmail.com>
…issions_only/index.js Co-Authored-By: Amaury Martiny <amaury.martiny@protonmail.com>
ianhe8x
pushed a commit
to plugblockchain/api.js
that referenced
this pull request
Jul 30, 2019
* Start of mortal tx * Swap to Mortal transcations by default * Update SubmittableExtrinsic.ts * WIP (pre master merge) * Remove eraLength, allow era to specify * Oops, linting.... it happens in the best of families * WIP debugging immortals * Re-surrect with working meta, and e2e tests * Update docs/examples/promise/07_make_transfer_with_allowed_block_permissions_only/index.js Co-Authored-By: Amaury Martiny <amaury.martiny@protonmail.com> * Update docs/examples/promise/07_make_transfer_with_allowed_block_permissions_only/index.js Co-Authored-By: Amaury Martiny <amaury.martiny@protonmail.com> * Remove useless birth/death calls
ianhe8x
pushed a commit
to plugblockchain/api.js
that referenced
this pull request
Jul 31, 2019
* Start of mortal tx * Swap to Mortal transcations by default * Update SubmittableExtrinsic.ts * WIP (pre master merge) * Remove eraLength, allow era to specify * Oops, linting.... it happens in the best of families * WIP debugging immortals * Re-surrect with working meta, and e2e tests * Update docs/examples/promise/07_make_transfer_with_allowed_block_permissions_only/index.js Co-Authored-By: Amaury Martiny <amaury.martiny@protonmail.com> * Update docs/examples/promise/07_make_transfer_with_allowed_block_permissions_only/index.js Co-Authored-By: Amaury Martiny <amaury.martiny@protonmail.com> * Remove useless birth/death calls
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.