Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Selected Display Address Format should be reflected in API #250

Closed
Swader opened this issue Feb 23, 2020 · 3 comments
Closed

Selected Display Address Format should be reflected in API #250

Swader opened this issue Feb 23, 2020 · 3 comments

Comments

@Swader
Copy link

@Swader Swader commented Feb 23, 2020

web3Accounts() in extension-dapp fetches accounts in Substrate format, no matter what's selected as the display format option in the extension's settings. The API should either be updated to include address type as a param, or it should fetch whatever is selected in the settings.

@Tbaut
Copy link
Contributor

@Tbaut Tbaut commented Sep 7, 2020

I've actually had the "surprise" as an api user, so 100% agree with this issue. I would tend to go the route of the api enhancement by adding an option to choose the addressEncodingPrefix since it's a none breaking change. Does that sound good to you @jacogr ?

@Tbaut Tbaut self-assigned this Sep 7, 2020
@jacogr
Copy link
Contributor

@jacogr jacogr commented Sep 7, 2020

The ss58Format is display-only and it is certainly not up to the extension to dictate how any app displays it. Will look at anything non-breaking.

@polkadot-js-bot
Copy link

@polkadot-js-bot polkadot-js-bot commented May 31, 2021

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue if you think you have a related problem or query.

@polkadot-js polkadot-js locked as resolved and limited conversation to collaborators May 31, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

4 participants