Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Title attribute on buttons #138

Closed
0x3333 opened this issue Jan 28, 2019 · 5 comments

Comments

Projects
None yet
2 participants
@0x3333
Copy link

commented Jan 28, 2019

  • BUG
  • FEATURE

What happened:
None of the buttons have the title attribute set. This is very annoying because a newbie will have problems identifying what a button does.

What did you expect to happen:
Hovering a button, a short description of what it does.

How to reproduce it (as minimally and precisely as possible):
Just hover some button, none have the title attribute.

Anything else we need to know?:
I can work on a PR, but I need some directions, there are not contribution guidelines, I don't know if you guys accept PRs.

Environment:

  • Trudesk Version: 1.0.5
  • OS (e.g. from /etc/os-release): Alpine Linux v3.8
  • Node.JS Version: v10.10.0
  • MongoDB Version: v3.7.0-4757-gc31a4d0fd5
  • Is this hosted on cloud.trudesk.io: No, Docker container

@0x3333 0x3333 changed the title Alt text on buttons Title attribute on buttons Jan 28, 2019

@polonel

This comment has been minimized.

Copy link
Owner

commented Jan 28, 2019

Thank you for reporting this issue. I have already started implementing this request.

The project does indeed accept pull requests and the contribution guidelines are still being written. A major code shift is already being worked on that will affect this. (I'm dropping Angular 1.7 and refactoring to React)

polonel added a commit that referenced this issue Jan 28, 2019

@0x3333

This comment has been minimized.

Copy link
Author

commented Jan 29, 2019

That's great!
So, I'll wait, as you already implemented in the new version.

Thanks!

@0x3333

This comment has been minimized.

Copy link
Author

commented Feb 1, 2019

Is that possible to run the Development version in a container? Is there any workaround?
I'll try in a couple of hours, but would like to get a heads-up.

@polonel

This comment has been minimized.

Copy link
Owner

commented Feb 1, 2019

Not easily. The Docker container is built off the docker branch, which gets merged with develop branch right before an update is released. You would have to merge develop into docker and then build the docker image once it's done.

I will be merging them this weekend with release 1.0.6

@0x3333

This comment has been minimized.

Copy link
Author

commented Feb 1, 2019

I see! Ok, I'll wait then. Thanks!

@polonel polonel closed this Mar 9, 2019

polonel added a commit that referenced this issue Apr 11, 2019

fix(backup): mongodb binaries for mongodb 4 windows #138
chore(database): added support for MongoDB Atlas (shards)

polonel added a commit that referenced this issue May 2, 2019

chore(release): 1.0.11
## [1.0.11](v1.0.10...v1.0.11) (2019-05-02)

### Bug Fixes

* **accounts:** crash if user had deleted tickets and was removed ([ce376b4](ce376b4))
* **accounts:** editing admin/agent ([8a973c7](8a973c7))
* **accounts:** issue not showing upload dialog ([38a4c85](38a4c85))
* **accounts:** passwords not updating ([c28d1ad](c28d1ad))
* **api:** v1 crash if ticket _id was incorrect ([eea4d20](eea4d20))
* **api:** v1 for group changes ([3d12667](3d12667))
* **api:** v2 removed ability to delete group if group had tickets ([35dbef8](35dbef8))
* **apiv1:** invalid response if group was not sent as obj [#175](#175) ([ee223ff](ee223ff))
* **backup:** mongodb binaries for mongodb 4 windows [#138](#138) ([052d6da](052d6da))
* **defaults:** loading incorrectly ([f4c2841](f4c2841))
* **editor:** missing routes ([2946d07](2946d07))
* **elasticsearch:** crash on rebuild ([bc0728b](bc0728b))
* **install:** crash if mongodb failed to connect ([76036b9](76036b9))
* **install:** invalid role name [#179](#179) ([643703e](643703e))
* **mailcheck:** TLS not being set correctly ([40627d0](40627d0))
* **mailcheck:** typo ([e5e387d](e5e387d))
* **permissions:** role hierarchy not allowing ticket status updates ([51029b6](51029b6))
* **profile:** removing user from all groups on profile save ([1e9accd](1e9accd))
* **test:** crash if missing config token object ([ac3fe81](ac3fe81))
* **test:** fixed ([e419f81](e419f81))
* **test:** updates ([969d3f2](969d3f2))
* **tickets:** attachments loader not initializing ([bd949b7](bd949b7))
* **tickets:** dropdown arrow not showing with certain themes ([b839551](b839551))
* **tickets:** sort icon color - themes ([9fbb391](9fbb391))
* **tickets:** xss fixes ([99c02fb](99c02fb))
* **ui:** bug with firefox displaying table incorrectly ([6967e74](6967e74))

### Performance Improvements

* **elasticsearch:** fixes ([eddc577](eddc577))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.