From fca4151f367c26262c1cd21d67d78c2fda178f34 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?J=C3=A9r=C3=B4me=20BOULMIER?= <jerome.boulmier@outlook.fr>
Date: Sun, 7 Apr 2019 11:32:55 -0400
Subject: [PATCH] fix(window): remove useless operator= and add default copy
 cstr (#1729)

Fixes compilation under GCC 9

The default copy constructor implicit generation is deprecated by C++ standard.

The window& operator=(const xcb_window_t win); operator seems to be useless.

Fixes #1728
Ref jaagr/xpp#16
---
 include/x11/window.hpp | 3 +--
 lib/xpp                | 2 +-
 src/x11/window.cpp     | 5 -----
 3 files changed, 2 insertions(+), 8 deletions(-)

diff --git a/include/x11/window.hpp b/include/x11/window.hpp
index 9490c3760..9ddfe9f45 100644
--- a/include/x11/window.hpp
+++ b/include/x11/window.hpp
@@ -12,10 +12,9 @@ class connection;
 
 class window : public xpp::window<connection&> {
  public:
+  window(const window&) = default;
   using xpp::window<class connection&>::window;
 
-  window& operator=(const xcb_window_t win);
-
   window reconfigure_geom(unsigned short int w, unsigned short int h, short int x = 0, short int y = 0);
   window reconfigure_pos(short int x, short int y);
   window reconfigure_struts(unsigned short int w, unsigned short int h, short int x, bool bottom = false);
diff --git a/lib/xpp b/lib/xpp
index ab6247ba7..d2ff2aaba 160000
--- a/lib/xpp
+++ b/lib/xpp
@@ -1 +1 @@
-Subproject commit ab6247ba7baee2c06d35534e81ae27f622ebd5b4
+Subproject commit d2ff2aaba6489f606bbcc090c0a78a8a3f9fcd1f
diff --git a/src/x11/window.cpp b/src/x11/window.cpp
index e22e4451e..35393ddc8 100644
--- a/src/x11/window.cpp
+++ b/src/x11/window.cpp
@@ -7,11 +7,6 @@
 
 POLYBAR_NS
 
-window& window::operator=(const xcb_window_t win) {
-  resource(connection(), win);
-  return *this;
-}
-
 /**
  * Reconfigure the window geometry
  */