Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add non-normalized cpu %percentage% #1516

Closed
BigRedEye opened this issue Nov 18, 2018 · 1 comment
Closed

Add non-normalized cpu %percentage% #1516

BigRedEye opened this issue Nov 18, 2018 · 1 comment
Labels
feature

Comments

@BigRedEye
Copy link
Contributor

Is your feature request related to a problem? Please describe.

Sometimes the normalized processor load (0% - 100%) is not very informative, especially in systems with a large number of cores.

Why does polybar need this feature?

Consider a system with 16 cores, then 100% load of one core will be drawn as 6% and each core has ~6 load levels. For example, both top and htop displays 100% as full load of only one core, therefore in such system full cpu usage will be displayed as 1600%. I think that this number may be better in some situations.

Describe the solution you'd like

Just add a "normalize-load" option to the config that defaults to true, for example: https://github.com/BigRedEye/polybar/commit/8c7b4e400659bf7550c473f0247afc146d6b8132

Describe alternatives you've considered

To implement this functionality I have to use a script module that simply copy-pastes code from cpu.cpp with a few modified lines, but it looks like a useful feature that can be easily implemented.
@patrick96
Copy link
Member

Good idea! Could you please open a PR for those changes?

@BigRedEye BigRedEye mentioned this issue Nov 19, 2018
Merged
patrick96 added a commit that referenced this issue Dec 23, 2018
@patrick96
Release 3.3.0 (#1543)
c3ef99b 
### Breaking Changes:
None

### Changelog

**New Config Options**
The following config options were added

In the `[settings]` section:
* `pseudo-transparency`

In `internal/cpu`:
* `ramp-coreload-spacing`, spacing between elements in `<ramp-coreload>` elements
* `%percentage-sum%` in `label`. Shows sum of all percentages

In `custom/script`:
* `double-click-left`
* `double-click-middle`
* `double-click-right`

In `internal/pulseaudio`:
* `interval`, volume increase and decrease steps in percentage points

In `internal/memory`:
* `bar-swap-used`
* `bar-swap-free`
* `ramp-swap-used`
* `ramp-swap-free`

**Deprecations**
* `tray-transparent` in the bar section is no longer used. The tray now always uses pseudo-transparency

**Features**
* volume: adjustable volume steps (#1364), see #1361
* memory: Add progress bars and ramps for swap (#1325)
* render: pseudo-transparency (always used in the tray)  (#595)
* cpu: 
    * Configurable spacing in between coreloads (#1472), see #1389
    * Non-normalized cpu load (#1517), see #1516
* script: Double click actions (#1442)
* net: Support for bridge interfaces (#1528), see #1522
* token: zero pad tokens when min-width value starts with a `0` (#1341), see #1332

**Fixes**
* config: Use font patterns detected on system in sample config (#1350)
* net: Disconnected module when SSID is only an emoji (#1371), see #1367
* tray: Tray overlapping with bar (#1392), see #591
* build: Several build errors (#1395, #1454, #1470, polybar/xpp#12, #1493), see #1447, #1469, #750, #1492
* mpd: format-online-prefix not working (#1402), see #1399
* font: Crash for some font-patterns (#1451), see #1435
* script: 
    * Only `%counter%` or `%pid%` token usable, never both (#1456)
    * click actions with colons in them (#1457), see #984
* renderer: Bar locks up when xorg composite extension is disabled (#1430), see #1425
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@patrick96 @BigRedEye