fix(renderer): Correct center module position #673
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The changes introduced in 389bae2 to address polybar#551 did not consider the left border Now center modules are centered regardless of border (left or right) settings or tray position Fixes polybar#672
NBonaparte
force-pushed
the
center_module_pos
branch
from
85bd136
to
9f4430c
Compare
patrick96
added a commit
that referenced
this pull request
Dec 3, 2017
Breaking Changes: * Date module no longer supports non-padded specifiers (i.e. `%-d`) and potentially other specifiers, see #792 - Check http://en.cppreference.com/w/cpp/io/manip/put_time to see supported specifiers * Setting background color to `background-0` with gradients (refer to https://github.com/jaagr/polybar/wiki/Known-Issues) Changelog: Features: * Feat(mpd): State-specific formats (`format-playing`, `format-paused`, `format-stopped`) (#567), see #524 * Feat(ipc): Visibility commands (show, hide, toggle, restart, quit) (b6c5563) * Feat(shell): Bash completion (#588) * Feat(menu): `expand-right` option (#658), see #655 * Feat(temperature): hwmon sysfs support (#688), see #404 * Feat(cursor): Change cursors over clickable/scrollable areas (#727), see #721 * Feat(temperature): Fahrenheit and Celsius tokens (#804) * Feat(mpd): Use mpd name tag or URI as fallback for title-less tracks (#823), see #815 Fixes: * Fix(i3): Clicking workspaces without index (#521), see #520 * Fix(parser): Prefix options overriding format options (#729), see #544 * Fix(parser): Overline tags (eebf105) * Fix(process_util): Prefix shell environment variable (`$POLYBAR_SHELL`) (86ff947), see #566 * Fix(parser): `%{R}` tag (reverse colors) (0bd8f1f), see #585 * Fix(renderer): Center block position with tray (389bae2 & #673), see #551 & #672 * Fix(xworkpaces): Active workspace with XMonad (#587), see #411 & #535 * Fix(config): Expand tilde, environment variable (d3b0670 & #724), see #603 & #719 * Fix(build): Remove curlbuild.h (#648), see #647 * Fix(renderer): Off by one error for actions (#663), see #661 * Fix(gcc): GCC 7.1 ([jaagr/xpp/#6](polybar/xpp#6)) * Fix(fs): Use `bytes_available` for `percentage_used` (138f5fa), see #710 * Fix(fs): Use `f_frsize` for calculations (a682d2a) * Fix(date): Remove date string length limitation (#745), see #754 * Fix(renderer): Nested actions (#772), see #760 and #758 * Fix(i3): Check and warn if current workspace not found (#826), see #824 * Fix(github): Prevent module disappearing with no connection (#811), see #810 * Fix(renderer): Module gradients (#831), see #759 * Fix(build): Update deprecated jsoncpp Reader
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The changes introduced in 389bae2 to
address #551 did not consider the left border
Now center modules are centered regardless of border (left or right)
settings or tray position
Fixes #672