Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

Remove weird things from the Debug configuration. #41

Open
wants to merge 1 commit into from

1 participant

@madewokherd

Since Debug is apparently the default in MonoDevelop and is required for
running the tests, it should be a configuration suitable for development.
That means traces (which cause the tests to break) and IronAHK.Program.Start
(which causes my brain to break) are no good. If these are really needed, they
should be in another configuration that defines TRACE or WTF respectively.

I'm not REALLY expecting you to pull this commit unmodified (not that I think there's anything wrong with it), but please do something because not being able to run tests with MonoDevelop is really crappy.

@madewokherd madewokherd Remove weird things from the Debug configuration.
Since Debug is apparently the default in MonoDevelop and is required for
running the tests, it should be a configuration suitable for development.
That means traces (which cause the tests to break) and IronAHK.Program.Start
(which causes my brain to break) are no good. If these are really needed, they
should be in another configuration that defines TRACE or WTF respectively.
afe4c3d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Nov 30, 2011
  1. @madewokherd

    Remove weird things from the Debug configuration.

    madewokherd authored
    Since Debug is apparently the default in MonoDevelop and is required for
    running the tests, it should be a configuration suitable for development.
    That means traces (which cause the tests to break) and IronAHK.Program.Start
    (which causes my brain to break) are no good. If these are really needed, they
    should be in another configuration that defines TRACE or WTF respectively.
This page is out of date. Refresh to see the latest.
View
2  IronAHK/Debug.cs
@@ -23,7 +23,7 @@ internal static class SafeNativeMethods
internal static extern bool AllocConsole();
}
- [Conditional("DEBUG")]
+ [Conditional("WTF")]
static void Start(ref string[] args)
{
if (Environment.OSVersion.Platform == PlatformID.Win32NT)
View
3  IronAHK/IronAHK.csproj
@@ -41,7 +41,7 @@
<DebugType>full</DebugType>
<Optimize>false</Optimize>
<OutputPath>bin\Debug\</OutputPath>
- <DefineConstants>DEBUG;TRACE</DefineConstants>
+ <DefineConstants>DEBUG</DefineConstants>
<ErrorReport>prompt</ErrorReport>
<WarningLevel>4</WarningLevel>
<DebugSymbols>true</DebugSymbols>
@@ -63,6 +63,7 @@
<AssemblyOriginatorKeyFile>IronAHK.snk</AssemblyOriginatorKeyFile>
</PropertyGroup>
<Import Project="$(MSBuildToolsPath)\Microsoft.CSharp.targets" />
+ <Import Project="$(MSBuildBinPath)\Microsoft.CSharp.targets" />
<!-- To modify your build process, add your task inside one of the targets below and uncomment it.
Other similar extension points exist, see Microsoft.Common.targets.
<Target Name="BeforeBuild">
View
2  Scripting/Compiler/CompilerSetup.cs
@@ -109,7 +109,7 @@ void MineMethods(Type Typ)
}
}
- [Conditional("DEBUG")]
+ [Conditional("TRACE")]
void Debug(string message)
{
Console.WriteLine(message);
View
2  Scripting/Compiler/Emission/MethodSetup.cs
@@ -98,7 +98,7 @@ void GenerateEntryPointHeader(ILGenerator Generator)
Method.SetCustomAttribute(Attribute);
}
- [Conditional("DEBUG")]
+ [Conditional("TRACE")]
void Debug(string Message)
{
Console.Write(new string(' ', Depth));
View
2  Scripting/IACodeProvider.cs
@@ -129,7 +129,7 @@ public override CompilerResults CompileAssemblyFromDom(CompilerParameters option
#region Helpers
- [Conditional("DEBUG")]
+ [Conditional("TRACE")]
void PrintCode(CodeCompileUnit[] units, TextWriter writer)
{
var gen = new Generator();
View
3  Scripting/Scripting.csproj
@@ -39,7 +39,7 @@
<DebugType>full</DebugType>
<Optimize>false</Optimize>
<OutputPath>bin\Debug\</OutputPath>
- <DefineConstants>TRACE;DEBUG;LEGACY</DefineConstants>
+ <DefineConstants>DEBUG;LEGACY</DefineConstants>
<ErrorReport>prompt</ErrorReport>
<WarningLevel>4</WarningLevel>
<DebugSymbols>true</DebugSymbols>
@@ -54,6 +54,7 @@
<WarningLevel>4</WarningLevel>
</PropertyGroup>
<Import Project="$(MSBuildToolsPath)\Microsoft.CSharp.targets" />
+ <Import Project="$(MSBuildBinPath)\Microsoft.CSharp.targets" />
<!-- To modify your build process, add your task inside one of the targets below and uncomment it.
Other similar extension points exist, see Microsoft.Common.targets.
<Target Name="BeforeBuild">
View
3  Tests/Tests.csproj
@@ -40,7 +40,7 @@
<DebugType>full</DebugType>
<Optimize>false</Optimize>
<OutputPath>bin\Debug\</OutputPath>
- <DefineConstants>DEBUG;TRACE</DefineConstants>
+ <DefineConstants>DEBUG</DefineConstants>
<ErrorReport>prompt</ErrorReport>
<WarningLevel>4</WarningLevel>
<AllowUnsafeBlocks>true</AllowUnsafeBlocks>
@@ -146,6 +146,7 @@
</ItemGroup>
<ItemGroup />
<Import Project="$(MSBuildToolsPath)\Microsoft.CSharp.targets" />
+ <Import Project="$(MSBuildBinPath)\Microsoft.CSharp.targets" />
<!-- To modify your build process, add your task inside one of the targets below and uncomment it.
Other similar extension points exist, see Microsoft.Common.targets.
<Target Name="BeforeBuild">
Something went wrong with that request. Please try again.