Skip to content
This repository

Remove weird things from the Debug configuration. #41

Open
wants to merge 1 commit into from

1 participant

Vincent Povirk
Vincent Povirk

Since Debug is apparently the default in MonoDevelop and is required for
running the tests, it should be a configuration suitable for development.
That means traces (which cause the tests to break) and IronAHK.Program.Start
(which causes my brain to break) are no good. If these are really needed, they
should be in another configuration that defines TRACE or WTF respectively.

I'm not REALLY expecting you to pull this commit unmodified (not that I think there's anything wrong with it), but please do something because not being able to run tests with MonoDevelop is really crappy.

Vincent Povirk Remove weird things from the Debug configuration.
Since Debug is apparently the default in MonoDevelop and is required for
running the tests, it should be a configuration suitable for development.
That means traces (which cause the tests to break) and IronAHK.Program.Start
(which causes my brain to break) are no good. If these are really needed, they
should be in another configuration that defines TRACE or WTF respectively.
afe4c3d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Showing 1 unique commit by 1 author.

Nov 29, 2011
Vincent Povirk Remove weird things from the Debug configuration.
Since Debug is apparently the default in MonoDevelop and is required for
running the tests, it should be a configuration suitable for development.
That means traces (which cause the tests to break) and IronAHK.Program.Start
(which causes my brain to break) are no good. If these are really needed, they
should be in another configuration that defines TRACE or WTF respectively.
afe4c3d
This page is out of date. Refresh to see the latest.
2  IronAHK/Debug.cs
@@ -23,7 +23,7 @@ internal static class SafeNativeMethods
23 23
             internal static extern bool AllocConsole();
24 24
         }
25 25
 
26  
-        [Conditional("DEBUG")]
  26
+        [Conditional("WTF")]
27 27
         static void Start(ref string[] args)
28 28
         {
29 29
             if (Environment.OSVersion.Platform == PlatformID.Win32NT)
3  IronAHK/IronAHK.csproj
@@ -41,7 +41,7 @@
41 41
     <DebugType>full</DebugType>
42 42
     <Optimize>false</Optimize>
43 43
     <OutputPath>bin\Debug\</OutputPath>
44  
-    <DefineConstants>DEBUG;TRACE</DefineConstants>
  44
+    <DefineConstants>DEBUG</DefineConstants>
45 45
     <ErrorReport>prompt</ErrorReport>
46 46
     <WarningLevel>4</WarningLevel>
47 47
     <DebugSymbols>true</DebugSymbols>
@@ -63,6 +63,7 @@
63 63
     <AssemblyOriginatorKeyFile>IronAHK.snk</AssemblyOriginatorKeyFile>
64 64
   </PropertyGroup>
65 65
   <Import Project="$(MSBuildToolsPath)\Microsoft.CSharp.targets" />
  66
+  <Import Project="$(MSBuildBinPath)\Microsoft.CSharp.targets" />
66 67
   <!-- To modify your build process, add your task inside one of the targets below and uncomment it. 
67 68
        Other similar extension points exist, see Microsoft.Common.targets.
68 69
   <Target Name="BeforeBuild">
2  Scripting/Compiler/CompilerSetup.cs
@@ -109,7 +109,7 @@ void MineMethods(Type Typ)
109 109
             }
110 110
         }
111 111
 
112  
-        [Conditional("DEBUG")]
  112
+        [Conditional("TRACE")]
113 113
         void Debug(string message)
114 114
         {
115 115
             Console.WriteLine(message);
2  Scripting/Compiler/Emission/MethodSetup.cs
@@ -98,7 +98,7 @@ void GenerateEntryPointHeader(ILGenerator Generator)
98 98
             Method.SetCustomAttribute(Attribute);
99 99
         }
100 100
 
101  
-        [Conditional("DEBUG")]
  101
+        [Conditional("TRACE")]
102 102
         void Debug(string Message)
103 103
         {
104 104
             Console.Write(new string(' ', Depth));
2  Scripting/IACodeProvider.cs
@@ -129,7 +129,7 @@ public override CompilerResults CompileAssemblyFromDom(CompilerParameters option
129 129
 
130 130
         #region Helpers
131 131
 
132  
-        [Conditional("DEBUG")]
  132
+        [Conditional("TRACE")]
133 133
         void PrintCode(CodeCompileUnit[] units, TextWriter writer)
134 134
         {
135 135
             var gen = new Generator();
3  Scripting/Scripting.csproj
@@ -39,7 +39,7 @@
39 39
     <DebugType>full</DebugType>
40 40
     <Optimize>false</Optimize>
41 41
     <OutputPath>bin\Debug\</OutputPath>
42  
-    <DefineConstants>TRACE;DEBUG;LEGACY</DefineConstants>
  42
+    <DefineConstants>DEBUG;LEGACY</DefineConstants>
43 43
     <ErrorReport>prompt</ErrorReport>
44 44
     <WarningLevel>4</WarningLevel>
45 45
     <DebugSymbols>true</DebugSymbols>
@@ -54,6 +54,7 @@
54 54
     <WarningLevel>4</WarningLevel>
55 55
   </PropertyGroup>
56 56
   <Import Project="$(MSBuildToolsPath)\Microsoft.CSharp.targets" />
  57
+  <Import Project="$(MSBuildBinPath)\Microsoft.CSharp.targets" />
57 58
   <!-- To modify your build process, add your task inside one of the targets below and uncomment it. 
58 59
        Other similar extension points exist, see Microsoft.Common.targets.
59 60
   <Target Name="BeforeBuild">
3  Tests/Tests.csproj
@@ -40,7 +40,7 @@
40 40
     <DebugType>full</DebugType>
41 41
     <Optimize>false</Optimize>
42 42
     <OutputPath>bin\Debug\</OutputPath>
43  
-    <DefineConstants>DEBUG;TRACE</DefineConstants>
  43
+    <DefineConstants>DEBUG</DefineConstants>
44 44
     <ErrorReport>prompt</ErrorReport>
45 45
     <WarningLevel>4</WarningLevel>
46 46
     <AllowUnsafeBlocks>true</AllowUnsafeBlocks>
@@ -146,6 +146,7 @@
146 146
   </ItemGroup>
147 147
   <ItemGroup />
148 148
   <Import Project="$(MSBuildToolsPath)\Microsoft.CSharp.targets" />
  149
+  <Import Project="$(MSBuildBinPath)\Microsoft.CSharp.targets" />
149 150
   <!-- To modify your build process, add your task inside one of the targets below and uncomment it. 
150 151
        Other similar extension points exist, see Microsoft.Common.targets.
151 152
   <Target Name="BeforeBuild">
Commit_comment_tip

Tip: You can add notes to lines in a file. Hover to the left of a line to make a note

Something went wrong with that request. Please try again.