Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
How can I help with regards to Polylang's integration with Gutenberg and the REST API? #15
I am also writing on behalf of @manooweb.
Thank you very much for your interest and proposal.
Here are the features broken when we activate Gutenberg together with the current stable version of Polylang:
We have decided to rewrite the metabox to handle most of the compatibility with Gutenberg in React. However, here are the issues that we have identified for which we would need help:
Nice to fix:
So far, we have not identified any issue with the REST API. We could add our own routes or fields when needed. And Gutenberg allows us to filter its REST API calls when we need, for example to filter the content per language.
Thanks @Chouby. Could you add me as a contributor to this repo so I can assign this issue to myself as a way of keeping tabs on it?
To start replying to your points:
I'd like to be able to revert this change. However, in order to do so, we'd need to confirm the original reason for making change has been resolved. I believe it was ACF but we'd need to do a dive through the history to verify.
Supporting those existing filters seems feasible to me if you'd like to submit a pull request for it.
I've replied directly on that issue. We can continue the conversation there.
We discussed this some today in Slack and are open to reversing the order. Would you be willing to research, open a pull request, and test against a few plugins?
referenced this issue
Oct 26, 2018
Well in fact, our post pre-filling issue that was solved by WordPress/gutenberg#10660 and WordPress/gutenberg#10362 is now back in WordPress 5.0. I also noticed that these 2 pull requests did not completely fix our issue as some fields such as 'menu_order' or 'comment_status' are not read by the editor.
I opened a ticket in core trac: https://core.trac.wordpress.org/ticket/45250
Thanks for th ticket.
Currently we are obliged to put the languages panel in a plugin sidebar. So when we select a new language, the document sidebar is hidden. When we come back to the document sidebar, the taxonomies panels are refreshed and correctly filtered by the new language.
Our main concern is that this doesn't work for the page attributes panel. It looks like, unlike the taxonomies panels, the page attributes panel doesn't fire a new REST request when the document sidebar is refreshed. See WordPress/gutenberg#7565.
For us, this is a workaround, because the user workflow is worse with a languages panel in separate plugin sidebar compared to the current situation where the legacy metabox is in the document sidebar.
As a side note, I have added a new blocking point in the list. Although the cause is different, the consequence for us is the same as the 2 points which are already solved. We are unable to prefill a new post due to the different behavior between WP 4.9.8 + Gutenberg and WP 5.0. We have already discussed that in https://core.trac.wordpress.org/ticket/45250