Add error message on config paste failure #1375
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeremyrsmith
reviewed
Mar 7, 2023
| @@ -71,7 +72,8 @@ export class NotebookConfigEl extends Disposable { | |||
| const conf = new NotebookConfig(dependencies.conf, exclusions.conf, resolvers.conf, spark.conf, spark.template, kernel.envVars, kernel.scalaVersion, kernel.jvmArgs); | |||
| this.copyConfig(conf); | |||
| }), | |||
| button([], {}, ['Paste & Save Configuration']).click(() => this.pasteConfig()) | |||
| button([], {}, ['Paste & Save Configuration']).click(() => this.pasteConfig()), | |||
| this.pasteErrorMessage = para(['hide', 'error-message'], ['Paste failed - your clipboard does not contain valid JSON']) | |||
There was a problem hiding this comment.
Hmm, is it bad for the error message to always be hanging out in the DOM?
There was a problem hiding this comment.
Probably not bad (since it's so small), but no reason for it to either. I'll change it to be added in/out of the DOM instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses a smaller issue a user had where they couldn't tell why a notebook config paste had failed - it should ideally be surfaced in the UI.