Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

outputToTrace has a bad type #286

Closed
isovector opened this issue Nov 26, 2019 · 5 comments
Assignees

Comments

@isovector
Copy link
Collaborator

@isovector isovector commented Nov 26, 2019

outputToTrace :: (Show w, Member Trace r) => Sem (Output w ': r) a -> Sem r a

but should be

outputToTrace :: Member Trace r => (w -> String) => Sem (Output w ': r) a -> Sem r a

@juanpaucar

This comment has been minimized.

Copy link
Contributor

@juanpaucar juanpaucar commented Nov 28, 2019

Hi @isovector, I'd love to take this ticket. But, I'm just getting familiar with the library so I might have a PR for the weekend. Would that be okay with you? If so, could I get this issue assigned to me?

@isovector

This comment has been minimized.

Copy link
Collaborator Author

@isovector isovector commented Nov 28, 2019

Hi @juanpaucar --- feel free to tackle this, thanks! No rush on it :)

@juanpaucar

This comment has been minimized.

Copy link
Contributor

@juanpaucar juanpaucar commented Dec 2, 2019

@isovector I just wanted to confirm that the desired function signature is

outputToTrace :: Member Trace r => (w -> String) -> Sem (Output w ': r) a -> Sem r a

Replacing the second => with a -> on the signature you posted above.

Disclaimer: polisemy is so interesting and I've seen so many new things by reading the code that I don't know what is valid Haskell anymore 😅

@KingoftheHomeless

This comment has been minimized.

Copy link
Collaborator

@KingoftheHomeless KingoftheHomeless commented Dec 2, 2019

Addressed by #289.

@isovector

This comment has been minimized.

Copy link
Collaborator Author

@isovector isovector commented Dec 3, 2019

Thanks for this, @juanpaucar !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.