Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upoutputToTrace has a bad type #286
Labels
Comments
This comment has been minimized.
This comment has been minimized.
Hi @isovector, I'd love to take this ticket. But, I'm just getting familiar with the library so I might have a PR for the weekend. Would that be okay with you? If so, could I get this issue assigned to me? |
This comment has been minimized.
This comment has been minimized.
Hi @juanpaucar --- feel free to tackle this, thanks! No rush on it :) |
This comment has been minimized.
This comment has been minimized.
@isovector I just wanted to confirm that the desired function signature is outputToTrace :: Member Trace r => (w -> String) -> Sem (Output w ': r) a -> Sem r a
Replacing the second Disclaimer: polisemy is so interesting and I've seen so many new things by reading the code that I don't know what is valid Haskell anymore |
This comment has been minimized.
This comment has been minimized.
Addressed by #289. |
This comment has been minimized.
This comment has been minimized.
Thanks for this, @juanpaucar ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
outputToTrace :: (Show w, Member Trace r) => Sem (Output w ': r) a -> Sem r a
but should be
outputToTrace :: Member Trace r => (w -> String) => Sem (Output w ': r) a -> Sem r a