Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Effect class #118

Merged
merged 1 commit into from Jun 17, 2019

Conversation

Projects
None yet
1 participant
@isovector
Copy link
Collaborator

commented Jun 17, 2019

This thing was a vestige of the bad old days when you had to write
instances of classes things in Polysemy. It was a terrible experience,
and so we don't do that anymore. As a result, the only two instances of
Effect were for Union and Yo --- so I just inlined them.

Fixes #117

Remove Effect class
This thing was a vestige of the bad old days when you had to write
*instances* of classes things in Polysemy. It was a terrible experience,
and so we don't do that anymore. As a result, the only two instances of
`Effect` were for `Union` and `Yo` --- so I just inlined them.

@isovector isovector merged commit 6ffb4fd into master Jun 17, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@isovector isovector deleted the bye-felicia branch Jun 17, 2019

isovector added a commit that referenced this pull request Jun 19, 2019

Faster hoist, cleaned up Union (#120)
After the clean up in #118, I realized that we no longer need to define hoist in terms of weave. This should save some allocations. After that, I realized it was sort of stupid to keep all of the *Yo functions around. Literally nobody should call them, so I just inlined them into the Union versions.

Red diffs, yeah!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.