Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

github: add tag suggestion to checklist #1819

Merged
merged 1 commit into from Jan 25, 2021
Merged

Conversation

desimone
Copy link
Contributor

@desimone desimone commented Jan 25, 2021

Summary

Adds an entry to the checklist so we don't forget to tag. :)

Checklist:

  • add related issues
  • updated docs
  • updated unit tests
  • updated UPGRADING.md
  • ready for review

@desimone desimone added the docs Docs update required label Jan 25, 2021
@desimone desimone requested a review from a team as a code owner January 25, 2021 16:47
@desimone desimone requested review from wasaga and travisgroth and removed request for wasaga January 25, 2021 16:47
@codeclimate
Copy link

codeclimate bot commented Jan 25, 2021

Code Climate has analyzed commit 314d0c8 and detected 0 issues on this pull request.

View more on Code Climate.

@codecov
Copy link

codecov bot commented Jan 25, 2021

Codecov Report

Merging #1819 (314d0c8) into master (3a505d5) will decrease coverage by 0.0%.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           master   #1819     +/-   ##
========================================
- Coverage    57.5%   57.5%   -0.1%     
========================================
  Files         138     138             
  Lines        9919    9919             
========================================
- Hits         5707    5705      -2     
- Misses       3659    3660      +1     
- Partials      553     554      +1     
Impacted Files Coverage Δ
internal/autocert/manager.go 65.5% <0.0%> (-1.4%) ⬇️

Signed-off-by: Bobby DeSimone <bobbydesimone@gmail.com>
@desimone desimone merged commit 5b9d18b into master Jan 25, 2021
@desimone desimone deleted the gh/add-tag-to-checklist branch January 25, 2021 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Docs update required
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants