New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
authorize: add databroker server and record version to result, force sync via polling #2024
authorize: add databroker server and record version to result, force sync via polling #2024
Conversation
Code Climate has analyzed commit c918f14 and detected 0 issues on this pull request. View more on Code Climate. |
Codecov Report
@@ Coverage Diff @@
## master #2024 +/- ##
========================================
- Coverage 59.6% 59.6% -0.1%
========================================
Files 158 159 +1
Lines 10847 10908 +61
========================================
+ Hits 6469 6504 +35
- Misses 3640 3663 +23
- Partials 738 741 +3
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm unsure about waitForRecord
This conflicts with #2041. Will wait on that review before making changes. |
a22c27e
to
c918f14
Compare
Summary
Add
databroker_server_version
anddatabroker_record_version
to the rego policy and evaluator result. This is useful for auditing.UpdateRecord
so that it takes in the server version as well, and updates all 3 values within a transaction so that the version is consistentforceSync
works so that it polls for the record to appear instead of overwriting it. This is necessary so that we don't apply changes out of orderChecklist
improvement
/bug
/ etc)