authorize: grpc health check #2200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Code Climate has analyzed commit dbbfc99 and detected 0 issues on this pull request. View more on Code Climate. |
calebdoxsey
approved these changes
May 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Previously if multiple authorize endpoints are defined and one of them is down, it would continue receive traffic based on default round-robin request load balancing policy, that would result 1/n % of HTTP requests to fail.
This PR adds GRPC health check for
pomerium-authorizeGRPC cluster, that ensures reachability, and outlier detection that ensures authorize endpoint would be ejected if misconfigured.Related issues
Fixes https://github.com/pomerium/internal/issues/399
Checklist
improvement/bug/ etc)