Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

envoy: only allow embedding #2368

Merged
merged 1 commit into from Jul 19, 2021
Merged

envoy: only allow embedding #2368

merged 1 commit into from Jul 19, 2021

Conversation

calebdoxsey
Copy link
Contributor

Summary

Only allow embedded envoy unless OverrideEnvoyPath is set.

Related issues

Fixes https://github.com/pomerium/internal/issues/436

Checklist

  • reference any related issues
  • updated docs
  • updated unit tests
  • updated UPGRADING.md
  • add appropriate tag (improvement / bug / etc)
  • ready for review

@calebdoxsey calebdoxsey requested a review from a team as a code owner July 15, 2021 20:51
@calebdoxsey calebdoxsey requested a review from wasaga July 15, 2021 20:51
@codeclimate
Copy link

codeclimate bot commented Jul 15, 2021

Code Climate has analyzed commit 868bc48 and detected 0 issues on this pull request.

View more on Code Climate.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.2%) to 64.77% when pulling 868bc48 on cdoxsey/436-envoy-path-flag into cef08a1 on master.

@desimone desimone requested review from travisgroth and removed request for wasaga July 16, 2021 15:50
@desimone
Copy link
Contributor

\cc @travisgroth

@calebdoxsey calebdoxsey merged commit 1123de0 into master Jul 19, 2021
@calebdoxsey calebdoxsey deleted the cdoxsey/436-envoy-path-flag branch July 19, 2021 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@travisgroth travisgroth travisgroth approved these changes

Assignees
No one assigned
Labels
security
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@calebdoxsey @coveralls @desimone @travisgroth